svn commit: r317320 - in head: Mk audio/gmidimonitor audio/lv2core audio/patchage audio/raul audio/slv2 databases/dbf editors/libreoffice games/tuxmath games/tuxtype graphics/mapnik java/openjdk6 j...

[Eitan Adler]

On 4 May 2013 10:15, Bryan Drewery <bdrewery at freebsd.org> wrote:
> On 5/4/2013 9:12 AM, Eitan Adler wrote:
>> On 4 May 2013 10:06, Bryan Drewery <bdrewery at freebsd.org> wrote:
>>> Author: bdrewery
>>> Date: Sat May  4 14:06:08 2013
>>> New Revision: 317320
>>> URL: http://svnweb.freebsd.org/changeset/ports/317320
>>>
>>> Log:
>>>   - When DISABLE_MAKE_JOBS or MAKE_JOBS_UNSAFE is set, also set
>>>     MAKE_JOBS_NUMBER to 1. This makes it safe to do -j${MAKE_JOBS_NUMBER}
>>>     without any extra logic.
>>
>> No.  It does not make this safe unless -B is also specified to make.
>>
>> It is possible that a Makefile will work with "make" but be buggy when
>> "make -j1" is used.
>>
>
> How is -j1 not safe? I test built these and they were fine.

Its been a *long* time since I looked but I seem to remember that -j:

- changes which features are available (disables 'compatibility mode')
- changes the order in which certain dependencies are evaluated

I am not saying that these ports will break, but that it is not a
direct consequence: it needs to be tested each time.

-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams