svn commit: r315624 - head/net/wireshark

[Chris Rees]

On 31 March 2013 17:11, Bryan Drewery <bdrewery at freebsd.org> wrote:
> On 3/31/2013 11:02 AM, Chris Rees wrote:
>> On 30 March 2013 21:55, Niclas Zeising <zeising at freebsd.org> wrote:
>>> On 03/30/13 21:45, Joe Marcus Clarke wrote:
>>>> Author: marcus
>>>> Date: Sat Mar 30 20:45:00 2013
>>>> New Revision: 315624
>>>> URL: http://svnweb.freebsd.org/changeset/ports/315624
>>>>
>>>> Log:
>>>>   Make pkgconfig an explicit dependency of tshark.
>>>>
>>>> Modified:
>>>>   head/net/wireshark/Makefile
>>>>
>>>> Modified: head/net/wireshark/Makefile
>>>> ==============================================================================
>>>> --- head/net/wireshark/Makefile       Sat Mar 30 18:54:34 2013        (r315623)
>>>> +++ head/net/wireshark/Makefile       Sat Mar 30 20:45:00 2013        (r315624)
>>>> @@ -75,7 +75,7 @@ USE_GNOME+= gtk20
>>>>  WIRESHARK_LIBS+=${PTHREAD_LIBS}
>>>>  .else
>>>>  PLIST_SUB+=  WIRESHARK="@comment wireshark not built"
>>>> -USE_GNOME+=  glib20
>>>> +USE_GNOME+=  glib20 pkgconfig
>>>>  CONFIGURE_ARGS+=     --enable-wireshark=no \
>>>>                       --disable-gtktest
>>>>  .endif
>>>>
>>>
>>> You should use USE_PKGCONFIG=build instead.
>>>
>>> A completely other thing:
>>> Isn't the ports tree frozen these days and require a Approved by:
>>> portmgr line in the commit msg?  Perhaps something isn't working as it
>>> should there.
>>> Regards!
>>
>> Those hooks are not working at the moment, though I don't remember if
>> I specifically told Beat about it or just complained.
>>
>> I've copied him in just in case he didn't know.
>>
>> Another example:
>>
>> http://svnweb.freebsd.org/ports/svnadmin/conf/access?revision=314635&view=markup
>>
>> Chris
>>
>
> The hook is working. portmgr are explicitly exempt from the check for
> "Approved by". See svnadmin/hooks/scripts/approvecheck.pl

Maybe I'm being picky, but the traditional method for this is to use
Approved by: portmgr (implicit) or Approved by: portmgr (self); have a
look at how it's done in base:

http://svnweb.freebsd.org/base/svnadmin/conf/access?revision=245526&view=markup

This makes it more explicit for the history when people nose back
years later [yes, there are people sad enough to do that].

Chris