svn commit: r321445 - head/mail/gnarwl

[Alexey Dokuchaev]

On Thu, Jun 20, 2013 at 11:23:05PM -0700, Jason Helfman wrote:
> > @@ -18,7 +18,7 @@ USE_GMAKE=    yes
> >  USES=          iconv
> >  USE_OPENLDAP=  yes
> >  GNU_CONFIGURE= yes
> > -CONFIGURE_ARGS+=--with-docdir=${DOCSDIR}
> > +CONFIGURE_ARGS=        --with-docdir=${DOCSDIR}
> >
> >  MAN8=          damnit.8 gnarwl.8
> >  MANCOMPRESSED= yes
> 
> It may look more pretty, but in the end your original commit didn't clobber
> any pre-existing CONFIGURE_ARGS that may have been set by the user. This
> one does.

We never supported preset (users) CONFIGURE_ARGS, and it would be silly
thing if we did (contrary to CC/CFLAGS).  There is an umpteen number of
configure scripts out there, both coming from different, often incompatible
versions of autotools or written manually, and handling any CONFIGURE_ARGS
in /etc/make.conf would likely break a lot of ports.  User is not supposed
to mess with them on that global level.

It's maintainer's duty to ensure that port provides appropriate configure
arguments; if user is smart/brave enough to change them, we must assume
that we knows what he's doing, and can edit Makefile directly.  That said,
CONFIGURE_ARGS= is correct here.

./danfe