svn commit: r320973 - head/audio/grip

Alexey Dokuchaev danfe at FreeBSD.org
Sat Jun 15 09:20:43 UTC 2013


On Sat, Jun 15, 2013 at 01:06:06PM +0400, Boris Samorodov wrote:
> The shlib ABI version was removed from LIB_DEPENDS and it was not
> reflected at the log. So the question arises if it was intended.
> Imho (yep, it's really imho) this change is serious enough to go
> to the log.

While I support you here on necessity of documenting every change in the
commit log, dropping ABI versions from LIB_DEPENDS had been common practice
for a while now, and can be forgiven.  We have much worse examples of
commits documented with one-liner log (which is bogus most of the times);
now, *that* is a problem. :(

> Second, the package definitely had changed. The dependency had
> changed from libcurl.so.6 to libcurl.so. And this is recorded
> at the package.

I didn't know we're recording fully expanded shlibs in +CONTENTS.  Library
versions are recorded inside the binaries, but in this case, dropping them
from LIB_DEPENDS should be no-op.

./danfe


More information about the svn-ports-head mailing list