svn commit: r323298 - head/games/ltris

[John Marino]

On 7/19/2013 19:01, Adam Weinberger wrote:
>>> (2013/07/19 @ 1037 EST): Alexey Dokuchaev said, in 1.1K: <<
>>>  	@${REINPLACE_CMD} -e 's|/icons|/pixmaps|g' ${WRKSRC}/Makefile.in
>>>  	@${REINPLACE_CMD} -e 's|= @mixer_flag@|= @INTLLIBS@ @mixer_flag@|g ; \
>>>  		 s|--mode=666||g' ${WRKSRC}/src/Makefile.in
>>> +	@${REINPLACE_CMD} -e 's/^inline //' \
>>> +		${WRKSRC}/src/sdl.h ${WRKSRC}/src/tools.h
>>
>> I might be nit picking, but it's generally advised and preferred to use the
>> same separators for regex' that were previously used (that is, bars instead
>> of slashes here) in the Makefile, for consistency's sake.
>>> end of "Re: svn commit: r323298 - head/games/ltris" from Alexey Dokuchaev <<
> 
> Don't be That Guy. When you pick every style nit, it detracts from the
> importance of your substance nits.

On top of that, there could be good justification for using slashes in
one instance and bars in another.  they aren't always interchangeable.

So I agree, this isn't worth checking.