svn commit: r309908 - head/textproc/docproj
Glen Barber
gjb at FreeBSD.org
Thu Jan 3 23:50:16 UTC 2013
On Fri, Jan 04, 2013 at 08:41:54AM +0900, Hiroki Sato wrote:
> gj> Log:
> gj> Unset WITH_JADETEX if not otherwise specified.
> gj>
> [...]
>
> Please revert this and convert it to OPTIONS_DEFINE instead.
Converting this entire port to OPTIONSng has been on my todo list for
a few months now, but IMHO, this port overall is very messy.
> WITH_JADETEX=no by default makes explanations in files/JADETEX
> useless and is counterintuitive because a docproj package for
> releases has been built with WITH_JADETEX=yes for a long time. Some
> more clean-ups are needed for consistency, but simply setting "no" by
> default is still problematic and solves nothing IMO.
Is WITH_JADETEX=yes for release builds set in non-public build scripts?
All the release build scripts for head/, stable/9/, and stable/8/ set
WITH_JADETEX=no. In that case, I see no immediate chance for
regression, and nonintuitive behavior within the port itself is
prevented.
In any case, if reverting it is still necessary, I will do so.
Glen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20130103/a6f6b04e/attachment.sig>
More information about the svn-ports-head
mailing list