svn commit: r313059 - in head/net/yate: . files

[Baptiste Daroussin]

On Wed, Feb 27, 2013 at 06:57:51PM +0200, David Naylor wrote:
> Hi
> 
> On Wednesday, 27 February 2013 18:14:42 Baptiste Daroussin wrote:
> > See remarks below
> > 
> > On Wed, Feb 27, 2013 at 02:53:23PM +0000, Michael Scheidell wrote:
> > > -.if defined(NOPORTDOCS)
> > > +.if ${PORT_OPTIONS:MDOCS}
> > 
> > Here this should be .if ! ${PORT_OPTIONS:MDOCS}
> 
> I thought `.if empty(PORT_OPTIONS:MDOCS)` is preferred[1]?  Although I prefer 
> your approach...
> 
> Regards
> 
> [1] https://wiki.freebsd.org/Ports/Options/OptionsNG

There is no preference wiki says empty() while handbook says ! ${...} the reason
for the handbook to say ! ${} is that it is among some people more consistent. 

I have no opinion on this :)

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20130227/a2ff068e/attachment.sig>