svn commit: r312904 - head/net-im/imspector

[Marcelo Araujo]

2013/2/25 Po-Chien Lin <pclin at freebsd.org>

> Author: pclin
> Date: Mon Feb 25 04:25:37 2013
> New Revision: 312904
> URL: http://svnweb.freebsd.org/changeset/ports/312904
>
> Log:
>   - Add IPFW suuport [1] and enable it by default [2]
>   - Trim Makefile header [2]
>   - Remove invalid entry from MASTER_SITES
>   - Patch to fix clang compiling
>   - Tune pkg-plist to pet portlint(1)
>
>   PR:           ports/175765
>   Submitted by: Oleg_Sch <7zsfx at 7zsfx.info> [1]
>   Approved by:  Mikhail Tsatsenko <m.tsatsenko at gmail.com> (maintainer) [2]
>   Approved by:  swills (mentor)
>
>
Dear Po-Chien,

For my eyes, it is pretty much strange when we have two lines of "Approved
by" or more then one line of Submitted by or wherever, usually we use only
one line, and something like bellow:

Approve by:    Mikhail Tsatsenko <m.tsatsenko at gmail.com> (maintainer)
                      swills (mentor)

An example to submit:

PR:                   ports/1111 [1], ports/22222 [2], ports/33333 [3]
Submitted by:    Marcelo Araujo (maintainer) [1]
                        Swills [2]
                        Bill Gates [3]


I'm really not sure if we have it documented on P-Handbook, but as far as I
know, we always have it like this.

Best Regards,
-- 
Marcelo Araujo
araujo at FreeBSD.org