svn commit: r312354 - head/audio/xmp

Chris Rees utisoft at gmail.com
Sat Feb 16 14:41:41 UTC 2013


On 16 Feb 2013 14:24, "Emanuel Haupt" <ehaupt at critical.ch> wrote:
>
> Emanuel Haupt <ehaupt at FreeBSD.org> wrote:
> > Author: ehaupt
> > Date: Sat Feb 16 14:21:33 2013
> > New Revision: 312354
> > URL: http://svnweb.freebsd.org/changeset/ports/312354
> >
> > Log:
> >   - Work around a case where .if !exists(${ETCDIR}/${f}) fails
> >   - Consistent usage of %%ETCDIR%%
> >
> > Modified:
> >   head/audio/xmp/Makefile
> >   head/audio/xmp/pkg-plist
> >
> > Modified: head/audio/xmp/Makefile
> >
==============================================================================
> > --- head/audio/xmp/Makefile   Sat Feb 16 14:10:55 2013
> > (r312353) +++ head/audio/xmp/Makefile Sat Feb 16 14:21:33
> > 2013  (r312354) @@ -50,11 +50,9 @@ post-patch:
> >       @${REINPLACE_CMD} -e 's|\ install-conf||'
> > ${WRKSRC}/Makefile.in
> >  post-install:
> > -     ${MKDIR} ${PREFIX}/etc/xmp
> > +     ${MKDIR} ${ETCDIR}
> >  .for f in ${CONFIG_FILES}
>
> > -.if !exists(${ETCDIR}/${f})
>
> Can someone explain why this fails?

I can't see from the patch, but I assume you forgot to include
bsd.port.pre.mk.

I would encourage the latter version anyway, since it preserves the lazy
evaluation of ETCDIR, and doesn't cause a stat on every read of the
Makefile.

Chris


More information about the svn-ports-head mailing list