svn commit: r325807 - in head: . Mk

[Bryan Drewery]

On 8/31/2013 9:10 AM, Alexey Dokuchaev wrote:
> On Sat, Aug 31, 2013 at 01:56:08PM +0000, Bryan Drewery wrote:
>> New Revision: 325807
>> URL: http://svnweb.freebsd.org/changeset/ports/325807
>>
>> - Add USE_PACKAGE_DEPENDS_ONLY which will try installing dependencies
>>   from existing packages and not fallback on building from source.
>>
>>   This is useful for package building tools such as poudriere and tinderbox
>>   to avoid building from source and confusing the build log, if a dependency
>>   failed to build for some reason.
> 
> I actually don't quite see the use for any of them.  As for the build log,
> if I understand correctly what you're describing, usually it's *good* to
> "confuse" the log, as it's an indication of wrongly spelled _DEPENDS line.
> 
> Am I missing some really warranted usage scenario for these knobs?
> 
> ./danfe
> 

make build-depends USE_PACKAGE_DEPENDS
  This installs dependencies from packages if present, else, fallback on
source.

make build-depends USE_PACKAGE_DEPENDS_ONLY
  This installs dependencies from packages only.

It has nothing to do with misspelling anything.

These are used to install dependencies from packages using the ports
framework. The alternative is to have the package building tool install
the dependencies themselves, which tinderbox _and_ portbuild do wrong!
Why reinvent the wheel. Let the ports framework install depenencies with
'build-depends', and use packages from already built.

The reason for _ONLY is that if a dependency failed to build, a port
would still, in some race-condition cases, run build-depends, not find
the dependency packages, then try to build them. Having no network
access, it would hit fetch errors; it shouldn't be building missing
dependencies, it should immediately fail because dependencies were not met.

The PR has more information and linked patches which demonstrate the issue:

http://www.bayofrum.net/~crees/scratch/log.log

With fix:

http://www.bayofrum.net/~crees/scratch/loglog.log

-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20130831/7b7ca3c9/attachment.sig>