svn commit: r325041 - head/japanese/eb

[Jason Helfman]

On Wed, Aug 21, 2013 at 9:01 AM, John Marino <freebsd.contact at marino.st>wrote:

> On 8/21/2013 17:58, Jason Helfman wrote:
> > I thought I was making that clear.
> > The PR shouldn't have been committed as is, so it is for the committer
> > to resolve the issue.
>
> To be fair, while I believe there is an issue, I haven't proven it yet.
> I also took over the PR, so now it's my responsibility.
>
> Regards,
> John
>
>
Fair enough. What this is doing though is making gettext a build dependency
regardless if NLS is selected or not.

(nls disabled here)
$ make -V PORT_OPTIONS
  DOCS EXAMPLES IPV6
$ make -V USES
gettext perl5

(nls enabled here)
$ make -V PORT_OPTIONS
  DOCS EXAMPLES IPV6 NLS
$ make -V USES
gettext perl5

However the port doesn't disable NLS if it is not selected. It should
conditionally add gettext, as you've pointed out,
Unless of course it requires gettext regardless, which I have seen as well.

I did built it though, and it looks like it needs gettext regardless, and
it does break.

http://meatwad.mouf.net/rubick/poudriere/logs/bulk/91amd64-jgh/latest/logs/errors/ja-eb-4.4.3.log

And this log is with --disable-nls

http://meatwad.mouf.net/rubick/poudriere/logs/bulk/91amd64-jgh/latest/logs/errors/ja-eb-4.4.3.log

Sounds like an upstream bug, and when or if ever fixed, uses can be fixed
to be conditional.

-jgh

--
Jason Helfman          | FreeBSD Committer
jgh at FreeBSD.org     | http://people.freebsd.org/~jgh  | The Power to Serve