svn commit: r324438 - head/graphics/dcraw

[Boris Samorodov]

09.08.2013 20:30, Sunpoet Po-Chuan Hsieh пишет:
> On Fri, Aug 9, 2013 at 11:05 PM, Boris Samorodov <bsam at passap.ru> wrote:
> 
>> 09.08.2013 18:18, Sunpoet Po-Chuan Hsieh пишет:
>>> Author: sunpoet
>>> Date: Fri Aug  9 14:18:29 2013
>>> New Revision: 324438
>>> URL: http://svnweb.freebsd.org/changeset/ports/324438
>>>
>>> Log:
>>>   - Update to 9.19
>>>   - Cleanup Makefile header
>>>   - Update maintainer section
>>
>> Seems to be a typo: maintainer->maketar. However this change:
>> [...]
>>> -             ${INSTALL} -m 644
>> ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \
>>> +             sudo ${INSTALL} -m 644
>> ${MS_WRKSRC}/${PORTNAME}-${MS_VERSION}.tar.xz ${DISTDIR}/; \
>>
>> ...is rather strange. Sudo is not a dependency at the port (sudo is not
>> at the base either). And the whole thing assumed to be launched with
>> root privileges anyway.
> 
> Maintainer section is from line 34 to line 56, therefore maketar target is
> for maintainer only. I meant to generate the tarball as normal user, not
> superuser. That's why I add "sudo" here.

Got it. Some thoughts though:

. the name of the section is misleading; standerd tools name MAINTAINER
  section a place where MAINTAINER and COMMENT are located. Yea, I see
  caps and non-caps, but it's a misleading name anyway;

. so, is this section used only by maintainer? If yes, I'd say that
  a better place may be Makefile.local. Or if you would like to leave
  this section at Makefile then use a more strong separations like:
  # ============= the section is used only by maintainer ==========
  bla bla
  # ========++=============== end section =========================

-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve