svn commit: r324150 - head/astro/aa

[Alexey Dokuchaev]

On Fri, Aug 02, 2013 at 09:51:01AM +0200, Baptiste Daroussin wrote:
> On Fri, Aug 02, 2013 at 07:48:08AM +0000, Antoine Brodin wrote:
> > Author: antoine
> > Date: Fri Aug  2 07:48:07 2013
> > New Revision: 324150
> > URL: http://svnweb.freebsd.org/changeset/ports/324150
> > 
> > Log:
> >   Fix without gcc
> > [...]
> > -	@${REINPLACE_CMD} 's|CFLAGS=  -O2|CFLAGS+=|' ${WRKSRC}/makefile
> > +	@${REINPLACE_CMD} 's|CFLAGS=  -O2|CFLAGS+=| ; s|CC=|CC?=|' ${WRKSRC}/makefile
> 
> Why not using MAKE_ARGS= CC=${CC} here?
> That is how make(1) is designed to work, All variable are always
> overwritable by args, ?= is only to allow to overwrite from env.

:-)  I've started to write similar letter (and in fact, Antoine did not fix
numerous other bugs in this port), but decided I better just do it myself
in subsequent commit.  Working on it now...

./danfe