svn commit: r304474 - head/multimedia/cx88

[Guido Falsi]

On Wed, Sep 19, 2012 at 03:42:44AM +0000, Alexey Dokuchaev wrote:
> On Tue, Sep 18, 2012 at 11:34:47PM +0000, Guido Falsi wrote:
> > New Revision: 304474
> > URL: http://svn.freebsd.org/changeset/ports/304474
> > 
> > @@ -1,12 +1,8 @@
> > -# New ports collection makefile for:   cx88
> > -# Date created:        7 September 2008
> > -# Whom:                jah
> > -#
> > +# Created-by: jah
> >  # $FreeBSD$
> 
> - Created-by: tag is wrongly spelled and should be followed with tab I think

Right. Going to fix this, but not completely sure about the tab rule,
anyway it's the same for me, if a tab is preferred I'll add one.

> 
> - $ finger jah at freebsd.org
> [freebsd.org]
> Trying 69.147.83.40...
> finger: jah: no such user
> 
> - This should have been "Jason Harmening <jason.harmening at gmail.com>"
> 
> - Even for FreeBSD committers, please use their fully qualified identities

I intended to just rename the Whom: to Created by: and left the
identity as is. If a full identity is requested I'll ask the
maintainer if he approves this change(or prefers having just the
name or wants to remove the Created by: line).

BTW there are other ports(not many I admit) with nicknames not
present @freebsd.org so I thought it was allowed practice to use
nicknames too. What if a contributor espresses preference for
inserting just a nickname there?

I'm going to fix my mistake and the other problems as soon as I have an
answer from the maintainer.

-- 
Guido Falsi <madpilot at FreeBSD.org>