svn commit: r305403 - head/graphics/eos-movrec

[Boris Samorodov]

Hello Alex,

07.10.2012 01:05, Alex Kozlov пишет:

nice to see the port to become better. However there are some notes
about the commit.

> Author: ak
> Date: Sat Oct  6 21:05:12 2012
> New Revision: 305403
> URL: http://svn.freebsd.org/changeset/ports/305403
> 
> Log:
>   - Convert Makefile headers to new style
>   - Add DESKTOP_ENTRIES
>   - Pass maintainership to nemysis <nemysis at gmx.ch>

As for me this is too simplified commit log. May be added:

- Use bzip2 instead of zip tarball (greatly reduses the size)
- Remove duplicate PORTREVISION
- Remove the indefinite article from COMMENT
- Remove shlib version from the dependency
- convert and install icon *.png from *.ico

And those changes are definitely demand a PORTREVISION bump.

There are some notes inline.

>   PR:	ports/172342

Since you committed a different patch it's better to point this out.

>   Submitted by:	nemysis <nemysis at gmx.ch>
> 
> Modified:
>   head/graphics/eos-movrec/Makefile   (contents, props changed)
>   head/graphics/eos-movrec/distinfo   (contents, props changed)
> 
> Modified: head/graphics/eos-movrec/Makefile
> ==============================================================================
> --- head/graphics/eos-movrec/Makefile	Sat Oct  6 20:50:12 2012	(r305402)
> +++ head/graphics/eos-movrec/Makefile	Sat Oct  6 21:05:12 2012	(r305403)
> @@ -1,34 +1,42 @@
> -# New ports collection makefile for:	EOS camera movie record
> -# Date created:				15 Aug 2011
> -# Whom:					Alexey Dokuchaev <danfe at FreeBSD.org>
> -#
>  # $FreeBSD$
> -#
> +# Created by:	Alexey Dokuchaev <danfe at FreeBSD.org>

Imho this line should be the first one.

>  PORTNAME=	eos-movrec
>  DISTVERSION=	0.3.1_beta
>  PORTREVISION=	1
>  CATEGORIES=	graphics

I'm not sure, but may be this port belongs to multimedia?

> -MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/0.3_beta
> +MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/0.3_beta/
>
> -MAINTAINER=	ports at FreeBSD.org
> -COMMENT=	A program to capture short movies with Canon DSLR camera
> +MAINTAINER=	nemysis at gmx.ch
> +COMMENT=	Program to capture short movies with Canon DSLR camera

May be this is a matter of taste but I'll say that "Program to" may be
trimmed too.

>  LICENSE=	GPLv2
>  
> -LIB_DEPENDS=	gphoto2.2:${PORTSDIR}/graphics/libgphoto2
> +LIB_DEPENDS=	gphoto2:${PORTSDIR}/graphics/libgphoto2
> +BUILD_DEPENDS=	pnmtopng:${PORTSDIR}/graphics/netpbm
>  
> -USE_ZIP=	yes
> +USE_BZIP2=	yes
>  USE_CMAKE=	yes
> +CMAKE_VERBOSE=	yes

Seems to be a diagnistic only tool. Is it necessary for every build?

>  USE_QT4=	qmake_build moc_build rcc_build uic_build gui
>  
>  WRKSRC=		${WRKDIR}/${PORTNAME}-${DISTVERSION}
>  DISTVERSIONSUFFIX=	-src
> -PORTREVISION=	1
>  
> -PLIST_FILES=	bin/eos_movrec
> +PLIST_FILES=	bin/eos_movrec \
> +		share/pixmaps/${PORTNAME}.png
> +
> +DESKTOP_ENTRIES=	"EOS Camera Movie Record" "${COMMENT}" "${PORTNAME}" \
> +			"${PORTNAME:S/-/_/}" "Application;Graphics;" ${FALSE}
>  
>  post-patch:
>  	@${REINPLACE_CMD} -e 's,GLIBC,${OPSYS},' ${WRKSRC}/os_api.h
>  
> +post-build:
> +	@(cd ${WRKSRC} && ${LOCALBASE}/bin/winicontoppm -bestqual eos-movrec2.ico | \
> +		${LOCALBASE}/bin/pnmtopng > eos-movrec.png)

This is an interesting trick. Is it documented anywhere?

> +
> +post-install:
> +	${INSTALL_DATA} ${WRKSRC}/${PORTNAME}.png ${PREFIX}/share/pixmaps/
> +
>  .include <bsd.port.mk>
> 
> Modified: head/graphics/eos-movrec/distinfo
> ==============================================================================
> --- head/graphics/eos-movrec/distinfo	Sat Oct  6 20:50:12 2012	(r305402)
> +++ head/graphics/eos-movrec/distinfo	Sat Oct  6 21:05:12 2012	(r305403)
> @@ -1,2 +1,2 @@
> -SHA256 (eos-movrec-0.3.1_beta-src.zip) = 25897e7d173d6baa0cfa94a8e0ff5f3decf809d2644ddf2a492677c068efc0c3
> -SIZE (eos-movrec-0.3.1_beta-src.zip) = 5183470
> +SHA256 (eos-movrec-0.3.1_beta-src.tar.bz2) = 044cf8b6428d66d6d03c3df53103f985e5b669cad3c8f78a94f9ef308259deea
> +SIZE (eos-movrec-0.3.1_beta-src.tar.bz2) = 3955037

-- 
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve