svn commit: r307899 - head/benchmarks/super-smack

[Alex Kozlov]

On Wed, Nov 28, 2012 at 04:08:25PM +0000, Alexey Dokuchaev wrote:
> On Wed, Nov 28, 2012 at 03:04:17PM +0200, Alex Kozlov wrote:
> > On Wed, Nov 28, 2012 at 11:53:59AM +0000, Alexey Dokuchaev wrote:
> > > On Wed, Nov 28, 2012 at 11:09:39AM +0000, Alex Kozlov wrote:
> > > > New Revision: 307899
> > > > URL: http://svnweb.freebsd.org/changeset/ports/307899
> > > > 
> > > > +PGSQL_DESC=	Enable PostgreSQL support
> > > > +MYSQL_DESC=	Enable MySQL support
> > > > 
> > > In this case, generic descriptions should have been used.
> > > 
> > No, specific descriptions are still better.
> They are essentially the same modulo "enable" word, which was decided to
> remove some time ago.  In fact, "generic" descriptions are better since they
> mention that is it *database* support.  Doug removed the word "support" in
> r305288, which many folks disagree with, but it will be backed out one we
> will have dialog4ports committed, which will allow proper support for
> checklists and radiobuttons.  You can leave them now, but after r305288 will
> be backed out, I will ask you again to drop them.
Will do, my point was that 'MySQL support' is better than 'MySQL database'.
 
> > This was impossible to catch in vim, it should be automated like with WWW.
> > If this tag is obsolete, then portlint should display a warning. I can
> > implement the patch, but before that can you please point me to documentation
> > where it stated? Thanks.
> It is not technically obsolete; sometimes it is the only attribution we
> can provide.  If there is actual WWW page, it should be dropped.
It looks not hard to implement. Is it documented somewhere?

Thanks for your reviews.


-- 
Alex