svn commit: r307927 - head/www/reviewboard

Frederic Culot culot at FreeBSD.org
Wed Nov 28 19:28:04 UTC 2012


> Hi Frederic,
> 
> Frederic Culot wrote on 28.11.2012 22:30:
> >Author: culot
> >Date: Wed Nov 28 18:30:23 2012
> >New Revision: 307927
> >URL: http://svnweb.freebsd.org/changeset/ports/307927
> >
> >Log:
> >   - Update to 1.6.14 [1]
> >   - use dirrmtry in plist for shared python directories to silence
> >     pkg_delete warnings
> 
> [...]
> 
> >  @dirrm %%PYTHON_SITELIBDIR%%/%%PYEASYINSTALL_EGG%%
> >- at dirrm %%PYTHON_SITELIBDIR%%
> >- at dirrm lib/python2.7
> >+ at dirrmtry %%PYTHON_SITELIBDIR%%
> >+ at dirrmtry lib/python2.7
> 
> They should be just removed altogether, because this directories
> were created by python port, not that reviewboard port. The second
> note - plist entries should not contain hardcoded paths like
> lib/python2.7, because in case user prefer to use python 2.6 or 3.2,
> this path will be lib/python2.6 and lib/python3.2. There is
> %%PYTHON_LIBDIR%% for such things, but it doesn't matter in this
> case, because they just should be removed.
> 
> -- 
> Regards,
> Ruslan
> 
> Tinderboxing kills... the drives.

Hi Ruslan,

I was not sure about this but you are right, there is no need to keep
them in plist. I just committed a patch to remove them.

Many thanks for your feedback!

Frederic


More information about the svn-ports-head mailing list