svn commit: r307827 - in head/net-mgmt: . p5-BigIP-iControl

[Eitan Adler]

On 27 November 2012 10:53, Alexey Dokuchaev <danfe at freebsd.org> wrote:
> On Tue, Nov 27, 2012 at 10:49:56AM -0500, Eitan Adler wrote:
>> On 27 November 2012 10:37, Jason E. Hale <jhale at freebsd.org> wrote:
>> >> +
>> >> +RUN_DEPENDS= p5-SOAP-Lite>=0:${PORTSDIR}/net/p5-SOAP-Lite \
>> >> +             p5-MIME-Base64>=0:${PORTSDIR}/converters/p5-MIME-Base64
>> >> +BUILD_DEPENDS=       ${RUN_DEPENDS}
>> >
>> > It would be better to use BUILD_DEPENDS:=       ${RUN_DEPENDS}
>> > to avoid duplicate perl build dependency.
>>
>> Please see r289563:
>> According to portmgr: Explicit duplication > := > =
>
> This is very bogus.  I think it should be reconsidered.  := suits perfectly
> for the purpose, and we should not neglect this nifty make(1) feature.

I believe the concern was that build only depends would be added with
no consideration as to if they should also be run depends.  Note that
I still have no personal opinion on this, I am just explaining why
that commit message says what it does.


-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams