svn commit: r307701 - head/graphics/vigra

[Dima Panov]

24.11.2012 17:17, Jason E. Hale пишет:
> On Saturday, November 24, 2012 02:25:38 Dima Panov wrote:
>> Author: fluffy
>> Date: Sat Nov 24 02:25:38 2012
>> New Revision: 307701
>> URL: http://svnweb.freebsd.org/changeset/ports/307701
>>
>> Log:
>>    - Force to use gcc46+ if CC is not Clang.
>>
>>    Feature safe:	yes
>>
>> Modified:
>>    head/graphics/vigra/Makefile
>>
>> Modified: head/graphics/vigra/Makefile
>> ============================================================================
>> == --- head/graphics/vigra/Makefile	Sat Nov 24 02:23:00 2012	(r307700) +++
>> head/graphics/vigra/Makefile	Sat Nov 24 02:25:38 2012	(r307701) @@ -56,6
>> +56,12 @@ PLIST_SUB+=	PYTHON="@comment "
>>
>>   .include <bsd.port.pre.mk>
>>
>> +# Check for clang, else use gcc46+
>> +CPP_check!=	${CPP} --version | tr -d '()'
>> +.if !${CPP_check:Mclang}
>> +USE_GCC=	4.6+
>> +.endif
>> +
> I think it would be better to avoid the '!=' expansion and check for
> clang/clang++ with something like this:
>
> .if ${CC:T:Mclang} != "clang" && ${CXX:T:Mclang++} != "clang++"
> USE_GCC=        4.6+
> .endif
>
This construction doesn't cover situation when cc = clang (-current, for 
example, where WITH_CLANG_IS_CC is default), so I've used own check..


-- 
Dima Panov (fluffy at FreeBSD.org)
(KDE, Office)@FreeBSD team

Facebook: http://www.facebook.com/fluffy.khv
IRC: fluffy at EFNet, fluffykhv at FreeNode
twitter: fluffy_khv | skype: dima.panov