svn commit: r307265 - head/multimedia/xmms

Alexey Dokuchaev danfe at FreeBSD.org
Sat Nov 10 13:50:01 UTC 2012


On Sat, Nov 10, 2012 at 08:20:37AM -0500, Jason E. Hale wrote:
> On Saturday, November 10, 2012 09:44:01 Alexey Dokuchaev wrote:
> > New Revision: 307265
> > URL: http://svnweb.freebsd.org/changeset/ports/307265
> > 
> > Log:
> >   Apparently, in some cases (per what I observe here) using empty(...) for
> >   testing specific PORT_OPTIONS instead of kosher ! breaks the build.  Fix
> >   this.  While here, move the test below the target.
> > 
> That's because it should just be:
> .if empty(PORT_OPTIONS:MSIMD)
> 
> The ${...} should be removed.  The ! works too, but isn't any more kosher.

Shit, you're right!  I guess at this time point it does not make any sense to
change it back though (it's consistent with recommended way and I personally
like it better :-).

./danfe


More information about the svn-ports-head mailing list