svn commit: r306797 - head/emulators/bochs

[Chris Rees]

On 1 November 2012 15:41, Guido Falsi <madpilot at freebsd.org> wrote:
> On 11/01/12 14:48, Alexey Dokuchaev wrote:
>> On Thu, Nov 01, 2012 at 11:33:39AM +0000, Guido Falsi wrote:
>>> New Revision: 306797
>>> URL: http://svn.freebsd.org/changeset/ports/306797
>>>
>>> Log:
>>>   - Replace usage of !${PORT_OPTIONS:MFOO} with empty(PORT_OPTIONS:MFOO)
>>
>> Any reason for doing it this way?  AFAIK both forms are equivalent (in fact
>> I prefer the ! one, but with a space after exclamation mark).
>
> I have no preference, but the porter's handbook reports the empty() form
> as THE one. Most ports are following the examples there so I was
> conforming to it.
>
> To tell the truth I'm quite sure that I was the one who wrote the old
> lines when converting it to optionsng, at the time thee porter's
> handbook had still not been updated with optionsng examples.

Both usages are correct, but the empty() syntax was written into the
Porter's Handbook because some complex expressions failed if expressed
as ! ${:M}.

However, when challenged I couldn't reproduce these, so I updated the docs.

http://www.freebsd.org/cgi/query-pr.cgi?pr=docs/172662

It's waiting for anyone with a doc bit :)

Chris