svn commit: r301719 - head/databases/aolserver-nspostgres

[Niclas Zeising]

On 07/30/12 17:39, Bryan Drewery wrote:
> This is not the patch I sent in.
>
> As I said in the PR, I purposely moved DISTVERSIONSUFFIX to fix a
> portlint error, which still exists now.
>
> # portlint .
> FATAL: Makefile: DISTVERSIONSUFFIX appears out-of-order.
> FATAL: Makefile: order must be
> PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTREVISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKGNAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRACT_ONLY.
> 2 fatal errors and 0 warnings found.

Me and my mentor decided that it made more sense to keep 
DISTVERSIONSUFFIX where it is, since it is connected to the name of the 
port.  Looking closely at the output of portlint, DISTVERSIONSUFFIX 
should really be *before* PORTREVISION, not halfway down the makefile. 
That portlint grows quiet when it is put there is arguably a bug in 
portlint.

>
> Adding USE_LDCONFIG may change behavior as well. I had left it out as I
> had not tested it yet.

It is my understanding that all ports that install shared libraries 
should have USE_LDCONFIG=yes in their makefile.  Portlint tells you as 
much if I am not mistaken.
-- 
Niclas Zeising