svn commit: r308525 - head/www/chromium

[Alexey Dokuchaev]

On Sun, Dec 09, 2012 at 11:44:08AM +0000, Rene Ladan wrote:
> New Revision: 308525
> URL: http://svnweb.freebsd.org/changeset/ports/308525
> 
> Log:
>   Use empty() instead of negation to check for non-set options.

Why?  Technically they are equivalent, however:

  - !-form is given as an example in PH (Example 5-12);
  - In the same PH page, in the last note, empty() is only suggested as
    alternative syntax when tradition check cannot be used for some reason;
  - empty()-form is more error prone: it's relatively easy to make mistakes
    like empty(${FOO}) vs. correct emtpy(FOO) which go unnoticed as make(1)
    does not issue any warning;
  - Let's not increase diversity in syntax; most ports use !-form.

That said, please reconsider.  Thanks,

./danfe