svn commit: r308201 - head/mail/exmh2

[Cy Schubert]

In message <201212050758.qB57wwjg005243 at slippy.cwsent.com>, Cy Schubert 
writes:
> In message <20121204114110.GC5906 at gahrfit.gahr.ch>, Pietro Cerutti writes:
> > 
> > --1SQmhf2mF2YjsYvc
> > Content-Type: text/plain; charset=utf-8
> > Content-Disposition: inline
> > Content-Transfer-Encoding: quoted-printable
> > 
> > On 2012-Dec-04, 06:21, Cy Schubert wrote:
> > > Author: cy
> > > Date: Tue Dec  4 06:21:05 2012
> > > New Revision: 308201
> > > URL: http://svnweb.freebsd.org/changeset/ports/308201
> > >=20
> > > Log:
> > >   Use TCL/Tk 8.6. This fixes issues with the mail messages list "More..."
> > >   button.
> > >  =20
> > >   Assume care and feeding of this port.
> > >  =20
> > >   Feature safe:	yes
> > >=20
> > > Modified:
> > >   head/mail/exmh2/Makefile
> > >=20
> > > Modified: head/mail/exmh2/Makefile
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =
> > =3D=3D=3D=3D
> > > --- head/mail/exmh2/Makefile	Tue Dec  4 06:18:16 2012	(r30820
> > 0)
> > > +++ head/mail/exmh2/Makefile	Tue Dec  4 06:21:05 2012	(r30820
> > 1)
> > > @@ -14,7 +14,7 @@ CATEGORIES+=3D	mail tk
> > >  MASTER_SITES=3D	${MASTER_SITE_TCLTK} \
> > >  		SF
> > > =20
> > > -MAINTAINER?=3D	ports at FreeBSD.org
> > > +MAINTAINER?=3D	cy at FreeBSD.org
> > >  COMMENT?=3D	X11/TK based mail reader front end to MH
> > > =20
> > >  .if defined(JAPANESE_EXMH)
> > > @@ -23,10 +23,10 @@ BUILD_DEPENDS=3D	tclsh8.0jp:${PORTSDIR}/ja
> > >  WISH=3D		wish8.0jp
> > >  TCLSH=3D		tclsh8.0jp
> > >  .else
> > > -RUN_DEPENDS=3D	wish8.5:${PORTSDIR}/x11-toolkits/tk85
> > > -BUILD_DEPENDS=3D	tclsh8.5:${PORTSDIR}/lang/tcl85
> > > -WISH=3D		wish8.5
> > > -TCLSH=3D		tclsh8.5
> > > +RUN_DEPENDS=3D	wish8.6:${PORTSDIR}/x11-toolkits/tk86
> > > +BUILD_DEPENDS=3D	tclsh8.6:${PORTSDIR}/lang/tcl86
> > > +WISH=3D		wish8.6
> > > +TCLSH=3D		tclsh8.6
> > >  .endif
> > 
> > Might I suggest the following patch here?
> > 
> > =3D=3D BEGIN PATCH =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D
> > Index: Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > --- Makefile	(revision 308234)
> > +++ Makefile	(working copy)
> > @@ -23,10 +23,7 @@
> >  WISH=3D		wish8.0jp
> >  TCLSH=3D		tclsh8.0jp
> >  .else
> > -RUN_DEPENDS=3D	wish8.6:${PORTSDIR}/x11-toolkits/tk86
> > -BUILD_DEPENDS=3D	tclsh8.6:${PORTSDIR}/lang/tcl86
> > -WISH=3D		wish8.6
> > -TCLSH=3D		tclsh8.6
> > +USE_TK=3D		86
> >  .endif
> > =20
> >  # exmh is pretty useless without this, but it's not needed to build it.
> > @@ -55,7 +52,7 @@
> > =20
> >  do-build:
> >  	@cd ${WRKSRC} && ${SETENV} PREFIX=3D${PREFIX} TCLSH=3D${TCLSH} \
> > -		WISH=3D${PREFIX}/bin/${WISH} WRKSRC=3D${WRKSRC} \
> > +		WISH=3D${WISH} WRKSRC=3D${WRKSRC} \
> >  		${SCRIPTS_ENV} ${SH} ${SCRIPTDIR}/build
> > =20
> >  do-install:
> > =3D=3D END PATCH =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> =
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > 
> > Moreover, I've seen that 2.8.0 is out. It's buildable as long as you
> > 
> > D       files/patch-lib-folder.tcl
> > D       files/patch-lib-quote.tcl
> > D       files/patch-lib-uri.tcl
> > 
> > Unfortunately I'm not familiar enough with the interface to properly
> > run-test it.
> 
> Cool, thanks. I'll commit the first suggestion as soon as I get a chance. 
> And, I'll look into 2.8.0 when I get some free time.

I've managed to install 2.8.0 (using it now). However USE_TK=86 results in 
script invocation lines to set as /usr/local//usr/local/bin/tk8.6. I'm 
thinking of committing 2.8.0, then find the time to resolve the USE_TK 
issue later.


-- 
Cheers,
Cy Schubert <Cy.Schubert at komquats.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.