svn commit: r308132 - head/audio/amrcoder

[Pietro Cerutti]

On 2012-Dec-03, 12:05, Alex Dupre wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Pietro Cerutti ha scritto:
> > I see no reason, however, not to let the author supersede them with
> > more appropriate flags.
> 
> If they were appropriate, why have you changed them? :-) This is the
> exact reason why we want the user set these optimization flags. When
> there is a really good motivation to add higher optimization flags
> usually we have OPTIMIZED_CFLAGS OPTION.

Fair enough. After re-reading [1] I realize that optimization flags are
to be treated differently (i.e., removed) than other flags an author
might want to set.

[1] http://www.freebsd.org/doc/en/books/porters-handbook/book.html#dads-cflags

Thanks danfe and ale for the review!

-- 
Pietro Cerutti
The FreeBSD Project
gahr at FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20121203/b99c6eb4/attachment-0001.sig>