svn commit: r472022 - branches/2018Q2/security/bro

[Craig Leres]

Author: leres
Date: Fri Jun  8 19:52:02 2018
New Revision: 472022
URL: https://svnweb.freebsd.org/changeset/ports/472022

Log:
  MFH: r472014
  
  Update to 2.5.4 which fixes multiple memory allocation issues:
  
   - Multiple fixes and improvements to BinPAC generated code
     related to array parsing, with potential impact to all Bro's
     BinPAC-generated analyzers in the form of buffer over-reads
     or other invalid memory accesses depending on whether a
     particular analyzer incorrectly assumed that the
     evaulated-array-length expression is actually the number of
     elements that were parsed out from the input.
  
   - The NCP analyzer (not enabled by default and also updated
     to actually work with newer Bro APIs in the release) performed
     a memory allocation based directly on a field in the input
     packet and using signed integer storage. This could result
     in a signed integer overflow and memory allocations of
     negative or very large size, leading to a crash or memory
     exhaustion. The new NCP::max_frame_size tuning option now
     limits the maximum amount of memory that can be allocated.
  
  Other fixes:
  
   - A memory leak in the SMBv1 analyzer.
  
   - The MySQL analyzer was generally not working as intended,
     for example, it now is able to parse responses that contain
     multiple results/rows.
  
  Add gettext-runtime to USES to address a poudriere testport
  warning.
  
  Reviewed by:	matthew (mentor)
  Approved by:	matthew (mentor)
  Security:	2f4fd3aa-32f8-4116-92f2-68f05398348e
  Differential Revision:	https://reviews.freebsd.org/D15678
  
  Approved by:	ports-secteam (feld), matthew (mentor)

Modified:
  branches/2018Q2/security/bro/Makefile
  branches/2018Q2/security/bro/distinfo
  branches/2018Q2/security/bro/pkg-plist
Directory Properties:
  branches/2018Q2/   (props changed)

Modified: branches/2018Q2/security/bro/Makefile
==============================================================================
--- branches/2018Q2/security/bro/Makefile	Fri Jun  8 19:31:30 2018	(r472021)
+++ branches/2018Q2/security/bro/Makefile	Fri Jun  8 19:52:02 2018	(r472022)
@@ -2,7 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	bro
-PORTVERSION=	2.5.3
+PORTVERSION=	2.5.4
 CATEGORIES=	security
 MASTER_SITES=	https://www.bro.org/downloads/
 DISTFILES=	${DISTNAME}${EXTRACT_SUFX}
@@ -16,7 +16,7 @@ BROKEN_powerpc64=	Does not build: error: zero-size arr
 
 LIB_DEPENDS=	libGeoIP.so:net/GeoIP
 
-USES=		bison cmake:outsource compiler:c++11-lang ninja perl5 python shebangfix ssl
+USES=		bison cmake:outsource compiler:c++11-lang gettext-runtime ninja perl5 python shebangfix ssl
 
 CMAKE_ARGS+=	-DPYTHON_EXECUTABLE:PATH=${PYTHON_CMD}
 CXXFLAGS+=	-std=c++11 -Wall

Modified: branches/2018Q2/security/bro/distinfo
==============================================================================
--- branches/2018Q2/security/bro/distinfo	Fri Jun  8 19:31:30 2018	(r472021)
+++ branches/2018Q2/security/bro/distinfo	Fri Jun  8 19:52:02 2018	(r472022)
@@ -1,6 +1,6 @@
-TIMESTAMP = 1518744511
-SHA256 (bro-2.5.3.tar.gz) = 7384fa14e6cebc86488040877fc0bfd50868e969f0fa05178cef0116e4116225
-SIZE (bro-2.5.3.tar.gz) = 18514905
+TIMESTAMP = 1528300945
+SHA256 (bro-2.5.4.tar.gz) = 80daea433fa654f2602cf67b19b9121ff6ad57761bad73cc29020c4f490c5f1f
+SIZE (bro-2.5.4.tar.gz) = 18520847
 SHA256 (actor-framework-actor-framework-0.14.6_GH0.tar.gz) = cbc2033896fe41e42604de2f74673971718a40684996650157484485755f7720
 SIZE (actor-framework-actor-framework-0.14.6_GH0.tar.gz) = 1239451
 SHA256 (bro-bro-netmap-cf88debf487b31ab30dc3b5bac64783b4e49997e_GH0.tar.gz) = 383423f92932c3ef244194954708b3a237b4f37ebc358014f51dcb3b9786896b

Modified: branches/2018Q2/security/bro/pkg-plist
==============================================================================
--- branches/2018Q2/security/bro/pkg-plist	Fri Jun  8 19:31:30 2018	(r472021)
+++ branches/2018Q2/security/bro/pkg-plist	Fri Jun  8 19:52:02 2018	(r472022)
@@ -188,6 +188,7 @@ man/man8/bro.8.gz
 %%DATADIR%%/base/bif/plugins/Bro_MIME.events.bif.bro
 %%DATADIR%%/base/bif/plugins/Bro_Modbus.events.bif.bro
 %%DATADIR%%/base/bif/plugins/Bro_MySQL.events.bif.bro
+%%DATADIR%%/base/bif/plugins/Bro_NCP.consts.bif.bro
 %%DATADIR%%/base/bif/plugins/Bro_NCP.events.bif.bro
 %%DATADIR%%/base/bif/plugins/Bro_NTLM.events.bif.bro
 %%DATADIR%%/base/bif/plugins/Bro_NTLM.types.bif.bro