svn commit: r569288 - head/devel/bitkeeper

[Cy Schubert]

In message <20210327060528.d62mjonjx6776lsq at aniel.nours.eu>, Baptiste 
Daroussin
 writes:
> 
>
> --4foob2fxu5qn7xlx
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Fri, Mar 26, 2021 at 09:41:06PM -0700, Cy Schubert wrote:
> > In message <20210327040518.GA30283 at FreeBSD.org>, Alexey Dokuchaev writes:
> > > On Sat, Mar 27, 2021 at 02:45:05AM +0000, Cy Schubert wrote:
> > > > New Revision: 569288
> > > > URL: https://svnweb.freebsd.org/changeset/ports/569288
> > > >=20
> > > > Log:
> > > >   devel/bitkeeper: pet portlint: compress man pages
> > > >  =20
> > > >   Compress man pages satisfying portlint.
> > >
> > > Well, no, we compress manpages to satisfy common sense and save some
> > > disk space. :-)
> > >
> > > > ...
> > > > -	${MAKE_CMD} DESTDIR=3D${STAGEDIR}${PREFIX}/bitkeeper ${INSTALL_
> TARG=
> ET})
> > > > +	${MAKE_CMD} DESTDIR=3D${STAGEDIR}${PREFIX}/bitkeeper ${INSTALL_
> TARG=
> ET});=20
> > > \
> > > > +	${GZIP_CMD} ${STAGEDIR}${PREFIX}/bitkeeper/man/man1/*
> > > > +
> > > >=20
> > > >  .include <bsd.port.mk>
> > >
> > > Why not amend MANDIRS to include custom manpage directory so that the
> > > standard `compress-man' from b.p.m could do its work?  Also, you've
> > > inserted superfluous linefeed there.
> >=20
> > I forgot about that, thanks. I used MANPREFIX instead.
> >=20
>
> MANDIRS is the right thing to use, MANPREFIX is not support to be overwritt=
> en
> and only works by accident here.
>
> MANDIRS is the list of directories where we expect to lookup for manpages to
> compress them.
>
> Second if you do install manpages in unusual location, it is expected that =
> you
> add this location into manpath for the users to be able to actually access =
> those
> manpages.

As in a pkg-message advising users to add the man pages to their MANPATH.

>
> Somehow many ports seems to forget to do it. A good example of what to do h=
> ere
> is shown by the perl port which adds a perl5.conf to ETCDIR/man.d (so does =
> npm)
>
> Best regards,
> Bapt


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy at nwtime.org>    Web:  https://nwtime.org

	The need of the many outweighs the greed of the few.