svn commit: r568508 - head/devel/node-gyp

[Mathieu Arnold]

On Tue, Mar 16, 2021 at 11:10:16PM +0100, Juraj Lutter wrote:
> 
> > On 16 Mar 2021, at 22:17, Mathieu Arnold <mat at FreeBSD.org> wrote:
> > 
> > On Mon, Mar 15, 2021 at 09:02:55PM +0000, Juraj Lutter wrote:
> >> Author: otis
> >> Date: Mon Mar 15 21:02:55 2021
> >> New Revision: 568508
> >> URL: https://svnweb.freebsd.org/changeset/ports/568508
> >> 
> >> Log:
> >>  Add port: devel/node-gyp: a build frmework for building Node.js applications.
> > 
> > A few problems with this, and the next 2 ports added, so putting my
> > portmgr's hat on.
> > 
> > We do not add node modules to the ports tree.
> > We really do not add node modules to the ports tree.
> > 
> > If an application needs nodes modules to work, then the port for that
> > application needs to handle the modules installing, and put those in a
> > private place.
> > 
> > lib/node_modules is a really aweful place to put this.  As a side note,
> > if we were to add node modules to the ports tree, which we are not, it
> > would probably be libdata/node_modules or share/node_modules.
> > 
> > Please remove those ports.
> 
> 
> The rationale behind this is:
> - Upcoming textproc/kibana7 has “re2” node module bundled, which also contains
> a re2.node binary module, that (from distribution tarball) can be for Linux or Darwin.
> 
> - In order to build re2.node binary component for FreeBSD in poudriere without need for
> network access that would otherwise be needed, separate port seemed the most ellegant way.
> 
> I value your comment and any hints/advises are welcome.

The rationale being that given X ports that depend on a node module, you
will probably need more than X versions of that module because they
will all depend on incompatible versions of said module.

A port that requires node modules must provide its own.  It can
absolutely be by having an extra step for the maintainer to generate a
tarball with all the required modules that can simply be extracted as
needed.  I have not checked, but there are probably ports already doing
this.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20210316/db9962a1/attachment.sig>