svn commit: r533459 - head/Mk/Scripts

[Mathieu Arnold]

On Mon, May 04, 2020 at 10:49:34AM -0700, Bryan Drewery wrote:
> On 4/30/2020 7:48 AM, Mathieu Arnold wrote:
> > Author: mat
> > Date: Thu Apr 30 14:48:22 2020
> > New Revision: 533459
> > URL: https://svnweb.freebsd.org/changeset/ports/533459
> > 
> > Log:
> >   When one patch fails, continue with appling patches.
> >   
> >   This makes the process of make patch, fix fallout, make makepatch much
> >   easier as only one iteration is required.
> >   
> >   While there, refactor things around, and streamline messages passed
> >   between functions.
> >   
> >   PR:		244626
> >   Reported by:	cem
> > 
> 
> Will this fail between stages? If a files/patch-* patch fails it should
> not move on to extra patches as then makepatch / diffing will be wrong.
> Even patch-* can lead to being wrong when considering local (not in
> ports tree) patches.
> 
> I don't think this is good default behavior.

No, it will try to apply all patches, and report all the failures.

I am not sure where you are getting at.

If you run `make patch; make makepatch` the usage would have been broken
before and still is.

If you run `make patch makepatch`, the usage does not change, if
patching fails, it does not go into makepatch target, and if patching is
ok, then makepatch runs and updates your patches.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200506/d482353f/attachment.sig>