svn commit: r540489 - in head/devel/fhist: . files

[Alexey Dokuchaev]

On Fri, Jun 26, 2020 at 04:19:26PM +0200, Mathieu Arnold wrote:
> On Fri, Jun 26, 2020 at 01:59:12PM +0000, Alexey Dokuchaev wrote:
> > On Fri, Jun 26, 2020 at 03:47:52PM +0200, Mathieu Arnold wrote:
> > > Now, the patches in the ports tree need to have a correct and coherent
> > > behavior, and fuzzy patching gets it wrong from time to time.  This is
> > > why range information is not noise, but important metadata that we
> > > prefer to be correct all the time.
> > 
> > Well, to your definition of "we". :-)  But I get it: you prefer perfect
> > patches and noisy commit diffs; I prefer okayish (correctly applicable)
> > patches and cleaner commit diffs.
> 
> Well, "we" in that sentence is defined as "ports committers".  So you
> may want to personnally have patch play russian roulette with the
> patches from your ports, but this is not what we want.  We want patches
> that apply cleanly,

Me too.  I see no contradiction here.

> without patch having to randonly decide where it is going to put the
> different hunks.

As long as pathes are applied correctly, I prefer to sacrifice purity
to get cleaner commit diffs which, as someone frequently working with
history, I value a lot more.

./danfe