svn commit: r540489 - in head/devel/fhist: . files

[Mathieu Arnold]

On Fri, Jun 26, 2020 at 12:41:05PM +0000, Alexey Dokuchaev wrote:
> On Fri, Jun 26, 2020 at 10:34:36AM +0000, Fernando Apestegu??a wrote:
> > New Revision: 540489
> > URL: https://svnweb.freebsd.org/changeset/ports/540489
> > 
> > Log:
> >   devel/fhist: and fix bison issues and change maintership
> > 
> > Modified:
> >   head/devel/fhist/Makefile
> >   head/devel/fhist/files/patch-common_ac_time.h
> > 
> > Modified: head/devel/fhist/files/patch-common_ac_time.h
> > ==============================================================================
> > --- head/devel/fhist/files/patch-common_ac_time.h	Fri Jun 26 09:35:06 2020	(r540488)
> > +++ head/devel/fhist/files/patch-common_ac_time.h	Fri Jun 26 10:34:36 2020	(r540489)
> > @@ -1,6 +1,6 @@
> > ---- common/ac/time.h.orig	Wed Dec 18 02:09:57 2002
> > -+++ common/ac/time.h	Wed Dec 18 02:10:04 2002
> > -@@ -29,7 +29,7 @@
> > +--- common/ac/time.h.orig	2012-07-13 04:47:15 UTC
> > ++++ common/ac/time.h
> > +@@ -26,7 +26,7 @@
> >    * Catch-22: Dec Alpha OSF/1: need to include time.h before sys/time.h
> >    * before time.h
> >    */
> 
> Please, "svn revert" patches which forwent no functional changes prior
> to making commit.  It just clutters the diff and decreases SNR. :-(

In that particular case, it was correct to commit the patch, it has
functional change, the range information changed, and it is definitively
not just noise.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200626/fec641f0/attachment.sig>