svn commit: r539975 - in head/x11-themes: . slim-freebsd-dark-theme

Baptiste Daroussin bapt at FreeBSD.org
Tue Jun 23 12:40:12 UTC 2020


On Tue, Jun 23, 2020 at 12:25:16PM +0000, Mateusz Piotrowski wrote:
> Author: 0mp
> Date: Tue Jun 23 12:25:16 2020
> New Revision: 539975
> URL: https://svnweb.freebsd.org/changeset/ports/539975
> 
> Log:
>   New port: x11-themes/slim-freebsd-dark-theme
>   
>   SLiM is an acronym for "Simple Login Manager".
>   
>   Lightweight and easily configurable, SLiM requires minimal dependencies,
>   and none from the GNOME or KDE desktop environments. It therefore
>   contributes towards a lightweight system for users that also like to use
>   lightweight desktops such as Xfce, Openbox, and Fluxbox.
>   
>   This package is a minimalist FreeBSD black/red colors theme, using
>   the colors defined by the FreeBSD Foundation.
>   
>   WWW: https://github.com/gocobachi/slim-freebsd-dark-theme
>   
>   PR:		247490
>   Submitted by:	Miguel Gocobachi <miguel at gocobachi.mx>
>   Differential Revision:	https://reviews.freebsd.org/D25410
> 
> Added:
>   head/x11-themes/slim-freebsd-dark-theme/
>   head/x11-themes/slim-freebsd-dark-theme/Makefile   (contents, props changed)
>   head/x11-themes/slim-freebsd-dark-theme/distinfo   (contents, props changed)
>   head/x11-themes/slim-freebsd-dark-theme/pkg-descr   (contents, props changed)
> Modified:
>   head/x11-themes/Makefile
> 
> Modified: head/x11-themes/Makefile
> ==============================================================================
> --- head/x11-themes/Makefile	Tue Jun 23 12:14:51 2020	(r539974)
> +++ head/x11-themes/Makefile	Tue Jun 23 12:25:16 2020	(r539975)
> @@ -141,6 +141,7 @@
>      SUBDIR += sddm-freebsd-black-theme
>      SUBDIR += sierra-gtk-themes
>      SUBDIR += slim-freebsd-black-theme
> +    SUBDIR += slim-freebsd-dark-theme
>      SUBDIR += slim-freebsd-themes
>      SUBDIR += slim-themes
>      SUBDIR += thewidgetfactory
> 
> Added: head/x11-themes/slim-freebsd-dark-theme/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/x11-themes/slim-freebsd-dark-theme/Makefile	Tue Jun 23 12:25:16 2020	(r539975)
> @@ -0,0 +1,33 @@
> +# $FreeBSD$
> +
> +PORTNAME=	slim-freebsd-dark-theme
> +DISTVERSIONPREFIX=	v
> +DISTVERSION=	1.0
> +CATEGORIES=	x11-themes
> +
> +MAINTAINER=	miguel at gocobachi.dev
> +COMMENT=	Minimalist FreeBSD black/red colors theme for SLiM
> +
> +LICENSE=	BSD2CLAUSE
> +LICENSE_FILE=	${WRKSRC}/LICENSE
> +
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	gocobachi
> +
> +NO_ARCH=	yes
> +NO_BUILD=	yes
> +
> +PLIST_FILES=	${_THEMEDIR_REL}/background.png \
> +		${_THEMEDIR_REL}/panel.png \
> +		${_THEMEDIR_REL}/screenshot.png \
> +		${_THEMEDIR_REL}/slim.theme
> +
> +_THEMEDIR_REL=	share/slim/themes/slim-freebsd-dark-theme
> +_THEMEDIR=	${PREFIX}/${_THEMEDIR_REL}
> +
> +do-install:
> +	@${MKDIR} ${STAGEDIR}${_THEMEDIR}
> +	(cd ${WRKSRC} && \
> +		${COPYTREE_SHARE} . ${STAGEDIR}${_THEMEDIR} '! -name LICENSE ! -name README.md')

Won't it be easier to just INSTALL_DATA *.png *.theme ${STAGEDIR}${_THEMEDIR}
easier to read, easier to understand (and less resources consuming)

> +
> +.include <bsd.port.mk>
> 
> Added: head/x11-themes/slim-freebsd-dark-theme/distinfo
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/x11-themes/slim-freebsd-dark-theme/distinfo	Tue Jun 23 12:25:16 2020	(r539975)
> @@ -0,0 +1,3 @@
> +TIMESTAMP = 1592911411
> +SHA256 (gocobachi-slim-freebsd-dark-theme-v1.0_GH0.tar.gz) = ab5c75bdabb3621df5815998fbb56747c0861c0b43857be657802de059c8889c
> +SIZE (gocobachi-slim-freebsd-dark-theme-v1.0_GH0.tar.gz) = 72948
> 
> Added: head/x11-themes/slim-freebsd-dark-theme/pkg-descr
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/x11-themes/slim-freebsd-dark-theme/pkg-descr	Tue Jun 23 12:25:16 2020	(r539975)
> @@ -0,0 +1,11 @@
> +SLiM is an acronym for "Simple Login Manager".
> +
> +Lightweight and easily configurable, SLiM requires minimal dependencies,
> +and none from the GNOME or KDE desktop environments. It therefore contributes
> +towards a lightweight system for users that also like to use lightweight
> +desktops such as Xfce, Openbox, and Fluxbox.
> +
> +This package is a minimalist FreeBSD black/red colors theme, using
> +the colors defined by the FreeBSD Foundation.

I think this descripton should be rewritten:

The first part explain what slim is, imho this is useless this is redundant with
the slim package description.

I would trim the description to something like:
Minimalist FreeBSD black/red colors theme for the SLIM Login Manager, using the
colors defined by the FreeBSD Foundation.

WWW: https://github.com/gocobachi/slim-freebsd-dark-theme
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200623/4c84c8f1/attachment.sig>


More information about the svn-ports-all mailing list