svn commit: r526359 - in branches/2020Q1/www: tomcat85 tomcat9

Mon Feb 17 10:43:53 UTC 2020

Author: koobs
Date: Mon Feb 17 10:43:51 2020
New Revision: 526359
URL: https://svnweb.freebsd.org/changeset/ports/526359

Log:
  MFH: r526349 www/tomcat85,9: Improve port quality
  
    - Don't echo automatic actions unlike other manual actions
    - Don't perform ${RM} -R because the OPTIONS system takes @comment parts
      in pkg-plist into account, poudriere build does not complain.
    - Don't provide samples for XML schema files, these are NOT intended to
      be modified by the user
  
  PR:		243648
  Submitted by:	Michael Osipov <michael.osipov siemens com>
  Approved by:	VVD <vvd unislabs com>
  
  Approved by:	ports-secteam (blanket: ports compliance, bugfixes)

Modified:
  branches/2020Q1/www/tomcat85/Makefile
  branches/2020Q1/www/tomcat85/pkg-plist
  branches/2020Q1/www/tomcat9/Makefile
  branches/2020Q1/www/tomcat9/pkg-plist
Directory Properties:
  branches/2020Q1/   (props changed)

Modified: branches/2020Q1/www/tomcat85/Makefile
==============================================================================

--- branches/2020Q1/www/tomcat85/Makefile	Mon Feb 17 10:16:51 2020	(r526358)
+++ branches/2020Q1/www/tomcat85/Makefile	Mon Feb 17 10:43:51 2020	(r526359)
@@ -3,6 +3,7 @@
 
 PORTNAME=	tomcat
 PORTVERSION=	8.5.49
+PORTREVISION=	1
 CATEGORIES=	www java
 MASTER_SITES=	APACHE/${PORTNAME}/${PORTNAME}-${PORTVERSION:C/([0-9])(.*)/\1/}/v${PORTVERSION}/bin
 PKGNAMESUFFIX=	85
@@ -50,36 +51,21 @@ post-patch:
 do-install:
 	@${MKDIR} ${STAGEDIR}${TOMCAT_HOME}/logs
 	@${MKDIR} ${STAGEDIR}${TOMCAT_HOME}/endorsed
-	${CP} -R ${WRKSRC}/* ${STAGEDIR}${TOMCAT_HOME}
+	@${CP} -R ${WRKSRC}/* ${STAGEDIR}${TOMCAT_HOME}
 
 post-install:
 	@${RM} ${STAGEDIR}${TOMCAT_HOME}/bin/*.bat
-	(cd ${STAGEDIR}${TOMCAT_HOME}/conf &&\
-		for f in $$(find . -type f); do ${MV} $$f $$f.sample; done)
+	@(cd ${STAGEDIR}${TOMCAT_HOME}/conf &&\
+		for f in $$(find . -type f -not -name '*.xsd'); do ${MV} $$f $$f.sample; done)
 
 post-install-HOST_MANAGER-on:
-	(cd ${STAGEDIR}${TOMCAT_HOME}/webapps &&\
+	@(cd ${STAGEDIR}${TOMCAT_HOME}/webapps &&\
 		for f in host-manager/META-INF/context.xml host-manager/WEB-INF/web.xml; do \
 			${MV} $$f $$f.sample; done)
 
-post-install-HOST_MANAGER-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/host-manager
-
 post-install-MANAGER-on:
-	(cd ${STAGEDIR}${TOMCAT_HOME}/webapps &&\
+	@(cd ${STAGEDIR}${TOMCAT_HOME}/webapps &&\
 		for f in manager/META-INF/context.xml manager/WEB-INF/web.xml; do \
 			${MV} $$f $$f.sample; done)
-
-post-install-MANAGER-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/manager
-
-post-install-DOCS-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/docs
-
-post-install-EXAMPLES-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/examples
-
-post-install-ROOT-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/ROOT
 
 .include <bsd.port.mk>

Modified: branches/2020Q1/www/tomcat85/pkg-plist
==============================================================================
--- branches/2020Q1/www/tomcat85/pkg-plist	Mon Feb 17 10:16:51 2020	(r526358)
+++ branches/2020Q1/www/tomcat85/pkg-plist	Mon Feb 17 10:43:51 2020	(r526359)
@@ -60,11 +60,11 @@
 @sample %%T%%/conf/catalina.properties.sample
 @sample %%T%%/conf/context.xml.sample
 @sample %%T%%/conf/jaspic-providers.xml.sample
- at sample %%T%%/conf/jaspic-providers.xsd.sample
+%%T%%/conf/jaspic-providers.xsd
 @sample %%T%%/conf/logging.properties.sample
 @sample %%T%%/conf/server.xml.sample
 @sample %%T%%/conf/tomcat-users.xml.sample
- at sample %%T%%/conf/tomcat-users.xsd.sample
+%%T%%/conf/tomcat-users.xsd
 @sample %%T%%/conf/web.xml.sample
 %%T%%/temp/safeToDelete.tmp
 %%DOCS%%%%T%%/webapps/docs/BUILDING.txt

Modified: branches/2020Q1/www/tomcat9/Makefile
==============================================================================
--- branches/2020Q1/www/tomcat9/Makefile	Mon Feb 17 10:16:51 2020	(r526358)
+++ branches/2020Q1/www/tomcat9/Makefile	Mon Feb 17 10:43:51 2020	(r526359)
@@ -3,7 +3,7 @@
 
 PORTNAME=	tomcat
 PORTVERSION=	9.0.29
-PORTREVISION=	0
+PORTREVISION=	1
 CATEGORIES=	www java
 MASTER_SITES=	APACHE/${PORTNAME}/${PORTNAME}-${PORTVERSION:C/([0-9])(.*)/\1/}/v${PORTVERSION}/bin
 PKGNAMESUFFIX=	9
@@ -52,36 +52,21 @@ post-patch:
 do-install:
 	@${MKDIR} ${STAGEDIR}${TOMCAT_HOME}/logs
 	@${MKDIR} ${STAGEDIR}${TOMCAT_HOME}/endorsed
-	${CP} -R ${WRKSRC}/* ${STAGEDIR}${TOMCAT_HOME}
+	@${CP} -R ${WRKSRC}/* ${STAGEDIR}${TOMCAT_HOME}
 
 post-install:
 	@${RM} ${STAGEDIR}${TOMCAT_HOME}/bin/*.bat
-	(cd ${STAGEDIR}${TOMCAT_HOME}/conf &&\
-		for f in $$(find . -type f); do ${MV} $$f $$f.sample; done)
+	@(cd ${STAGEDIR}${TOMCAT_HOME}/conf &&\
+		for f in $$(find . -type f -not -name '*.xsd'); do ${MV} $$f $$f.sample; done)
 
 post-install-HOST_MANAGER-on:
-	(cd ${STAGEDIR}${TOMCAT_HOME}/webapps &&\
+	@(cd ${STAGEDIR}${TOMCAT_HOME}/webapps &&\
 		for f in host-manager/META-INF/context.xml host-manager/WEB-INF/web.xml; do \
 			${MV} $$f $$f.sample; done)
 
-post-install-HOST_MANAGER-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/host-manager
-
 post-install-MANAGER-on:
-	(cd ${STAGEDIR}${TOMCAT_HOME}/webapps &&\
+	@(cd ${STAGEDIR}${TOMCAT_HOME}/webapps &&\
 		for f in manager/META-INF/context.xml manager/WEB-INF/web.xml; do \
 			${MV} $$f $$f.sample; done)
-
-post-install-MANAGER-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/manager
-
-post-install-DOCS-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/docs
-
-post-install-EXAMPLES-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/examples
-
-post-install-ROOT-off:
-	@${RM} -R ${STAGEDIR}${TOMCAT_HOME}/webapps/ROOT
 
 .include <bsd.port.mk>

Modified: branches/2020Q1/www/tomcat9/pkg-plist
==============================================================================
--- branches/2020Q1/www/tomcat9/pkg-plist	Mon Feb 17 10:16:51 2020	(r526358)
+++ branches/2020Q1/www/tomcat9/pkg-plist	Mon Feb 17 10:43:51 2020	(r526359)
@@ -63,11 +63,11 @@
 @sample %%T%%/conf/catalina.properties.sample
 @sample %%T%%/conf/context.xml.sample
 @sample %%T%%/conf/jaspic-providers.xml.sample
- at sample %%T%%/conf/jaspic-providers.xsd.sample
+%%T%%/conf/jaspic-providers.xsd
 @sample %%T%%/conf/logging.properties.sample
 @sample %%T%%/conf/server.xml.sample
 @sample %%T%%/conf/tomcat-users.xml.sample
- at sample %%T%%/conf/tomcat-users.xsd.sample
+%%T%%/conf/tomcat-users.xsd
 @sample %%T%%/conf/web.xml.sample
 %%T%%/temp/safeToDelete.tmp
 %%DOCS%%%%T%%/webapps/docs/BUILDING.txt
