svn commit: r530864 - head/audio/fasttracker2

[Mathieu Arnold]

On Mon, Apr 06, 2020 at 03:29:27PM +0200, Emanuel Haupt wrote:
> Alexey Dokuchaev <danfe at freebsd.org> wrote:
> > On Mon, Apr 06, 2020 at 07:36:05AM +0000, Emanuel Haupt wrote:
> > > New Revision: 530864
> > > URL: https://svnweb.freebsd.org/changeset/ports/530864
> > > 
> > > Log:
> > >   - Restore accidentally removed Makefile header
> > >   - Provide an option to build with pulseaudio
> > > 
> > > ...
> > > @@ -29,14 +32,17 @@ DESKTOP_ENTRIES="FastTracker II" \
> > >  
> > >  PLIST_FILES=	bin/fasttracker2 share/pixmaps/ft2-clone.ico
> > >  
> > > -OPTIONS_DEFINE=	ALSA
> > > -OPTIONS_DEFAULT=ALSA
> > > +OPTIONS_DEFINE=	ALSA PULSEAUDIO
> > > +OPTIONS_DEFAULT=ALSA PULSEAUDIO
> > 
> > We typically do not enable PA by default in FreeBSD ports because
> > it's mainly Linuxish piece of software, unneeded under FreeBSD as
> > we have superior sound stack which offers similar, but better placed
> > and implemented functionality by itself.  It may be helpful in some
> > bizarre edge case usage scenario (which justifies having it as an
> > OPTION), but for most users r530864 would pull needless and often
> > unwanted dependency.
> 
> I'll keep that in mind for the next update (upstream has short release
> cycles).

Hi,

Unless upstream has a release cycle of a day, why not simply remove
PULSEAUDIO fron the OPTIONS_DEFAULT line and commit just that?

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200406/48e6f31d/attachment.sig>