svn commit: r514890 - in head/www/quark: . files

[Mathieu Arnold]

On Sun, Oct 20, 2019 at 02:55:56PM +0200, Tobias Kortkamp wrote:
> On Sun, Oct 20, 2019 at 12:10:52PM +0000, Mateusz Piotrowski wrote:
> > Author: 0mp
> > Date: Sun Oct 20 12:10:52 2019
> > New Revision: 514890
> > URL: https://svnweb.freebsd.org/changeset/ports/514890
> > 
> > Log:
> >   Update to the latest commit
> >   
> >   - Point MASTER_SITES to FreeBSD's servers as we seem to have to host the
> >     distfile on our own (I wasn't able to find a way to get a tarball from
> >     upstream servers). Also, add a "regenerate-distfile" target to ease
> >     the process of updating the distfile in the future.
> >   - Update MAKE_ARGS: setting CC there is no longer needed.
> >   - Remove config.mk patches: it is sufficient for the sake of the port to
> >     just remove the include statement from the Makefile.
> >   
> >   Changelog:
> >   https://git.suckless.org/quark/log.html
> >   
> >   Reported by:	BieHDC
> > 
> > Deleted:
> >   head/www/quark/files/
> > Modified:
> >   head/www/quark/Makefile
> >   head/www/quark/distinfo
> > 
> > Modified: head/www/quark/Makefile
> > ==============================================================================
> > --- head/www/quark/Makefile	Sun Oct 20 11:38:29 2019	(r514889)
> > +++ head/www/quark/Makefile	Sun Oct 20 12:10:52 2019	(r514890)
> > @@ -1,11 +1,11 @@
> >  # $FreeBSD$
> >  
> >  PORTNAME=	quark
> > -DISTVERSION=	g20180403
> > +DISTVERSION=	g20190923
> >  CATEGORIES=	www
> > -MASTER_SITES=	https://git.suckless.org/quark/snapshot/
> > +MASTER_SITES=	https://people.freebsd.org/~0mp/distfiles/
> 
> This should be LOCAL/0mp instead.  You will need to copy the distfile
> into your ~/public_distfiles  and wait for a bit for that to work.
> 
> > +do-patch:
> > +	${REINPLACE_CMD} -e '/^include config.mk$$/d' ${WRKSRC}/Makefile
> 
> There is no reason to overwrite the default do-patch here.  It will
> just make putting new patches under files/ in the future harder and
> breaks stuff like EXTRA_PATCH_TREE etc.  Please move this to
> post-patch.

On top of that, our policy is that patching in the Makefile should ONLY
be done when the thing that gets replaced is a variable.  Everything
else is static and MUST be patched using a patch file.

https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html#slow-patch-automatic-replacements

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20191020/a03a8c9b/attachment.sig>