svn commit: r518243 - head/x11-toolkits/qt5-gui

[Adriaan de Groot]

On Saturday, November 23, 2019 3:55:24 PM CET Alexey Dokuchaev wrote:
> > +RUN_DEPENDS=   xdg-open:devel/xdg-utils \
> > +               ${LOCALBASE}/include/vulkan/vulkan.h:devel/vulkan-headers
> 
> Commit log does not really explain how come a *header file* is needed
> at runtime.  If the problem is with `sysutils/qt5-qtdiag', shouldn't it
> be fixed instead?

Every consumer of qt5-gui would (potentially) need a BUILD_DEPENDS on vulkan 
headers. This seemed easier. Possibly RUN_DEPENDS is a bad choice; I'd put 
this in LIB_DEPENDS except that it's a headers-only dependency.
 
> Also, previously when Vulkan headers were only a bdep I didn't raise
> the question about why it was not made OPTIONal, but I do now.  There
> are plenty of Qt5 users who would likely never want to have any Vulkan
> bits on their systems.

Since this is a headers-only dependency which is only a few kB in size, we 
(kde@) decided to just install it rather than mess around with trying to make 
it OPTIONAL.

[ade]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20191123/81de55ef/attachment.sig>