svn commit: r501617 - head/databases/foundationdb

[Mathieu Arnold]

On Tue, May 14, 2019 at 12:25:52PM +0200, Tobias Kortkamp wrote:
> On Tue, May 14, 2019 at 12:20:14PM +0200, Mathieu Arnold wrote:
> > On Tue, May 14, 2019 at 10:45:25AM +0200, Tobias Kortkamp wrote:
> > > On Tue, May 14, 2019 at 04:44:18AM +0000, Vanilla I. Shu wrote:
> > > > Author: vanilla
> > > > Date: Tue May 14 04:44:18 2019
> > > > New Revision: 501617
> > > > URL: https://svnweb.freebsd.org/changeset/ports/501617
> > > > 
> > > > Log:
> > > >   Update to 6.1.6.
> > > > 
> > > > Modified:
> > > >   head/databases/foundationdb/Makefile
> > > >   head/databases/foundationdb/distinfo
> > > >   head/databases/foundationdb/pkg-plist
> > > > 
> > > > Modified: head/databases/foundationdb/Makefile
> > > > ==============================================================================
> > > > --- head/databases/foundationdb/Makefile	Tue May 14 04:43:43 2019	(r501616)
> > > > +++ head/databases/foundationdb/Makefile	Tue May 14 04:44:18 2019	(r501617)
> > > > @@ -2,7 +2,7 @@
> > > >  # $FreeBSD$
> > > >  
> > > >  PORTNAME=	foundationdb
> > > > -PORTVERSION=	6.1.1
> > > > +PORTVERSION=	6.1.6
> > > >  CATEGORIES=	databases
> > > >  
> > > >  MAINTAINER=	vanilla at FreeBSD.org
> > > > @@ -45,13 +45,16 @@ do-install:
> > > >  	${INSTALL_PROGRAM} ${WRKSRC}/bin/fdbbackup ${STAGEDIR}${PREFIX}/bin
> > > >  	${INSTALL_PROGRAM} ${WRKSRC}/bin/fdbcli ${STAGEDIR}${PREFIX}/bin
> > > >  	${LN} -sf ${PREFIX}/bin/fdbbackup ${STAGEDIR}${PREFIX}/bin/fdbrestore
> > > > -	${INSTALL_PROGRAM} ${WRKSRC}/bin/fdbmonitor ${STAGEDIR}${PREFIX}/sbin
> > > > -	${INSTALL_PROGRAM} ${WRKSRC}/bin/fdbserver ${STAGEDIR}${PREFIX}/sbin
> > > > +	${INSTALL_PROGRAM} ${WRKSRC}/lib/libfdbclient.a ${STAGEDIR}/${PREFIX}/lib
> > > > +	${INSTALL_PROGRAM} ${WRKSRC}/lib/libfdbrpc.a ${STAGEDIR}/${PREFIX}/lib
> > > > +	${INSTALL_PROGRAM} ${WRKSRC}/lib/libflow.a ${STAGEDIR}/${PREFIX}/lib
> > > 
> > > Why strip and install the static libraries with executable permissions?
> > > Normally we use INSTALL_DATA to install static libraries.
> > 
> > Stripping static libraries will most likely break them, so, no, we don't
> > do this.
> 
> INSTALL_DATA does not strip anything.

Yes, you said what to do in an interrogative way, I explained why it
should be done.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190514/6b67f910/attachment.sig>