svn commit: r483807 - in head: Mk Mk/Uses audio/kwave audio/logitechmediaserver audio/supercollider audio/teamspeak3-server audio/wavpack audio/zynaddsubfx base/binutils cad/calculix cad/linuxcnc-d...

[Emanuel Haupt]

On 10.07.19 03:37, Gerald Pfeifer wrote:
> On Sat, 3 Nov 2018, Gerald Pfeifer wrote:
>>> Modified: head/cad/openscad/Makefile
>>> ==============================================================================
>>> -#.if ${ARCH} == i386 && ${OSVERSION} >= 1100000
>>> +#.if ${ARCH} == i386
>>>  #USE_GCC=        yes
>>>  #.endif
>> Yes, but this was dead code before and is still dead code.
>>
>> Okay to remove this, Michael?
> 
> I see you made this change five months later as part of
> 
>   r495203 | mr | 2019-03-09 21:11:35 +0000 (Sa., 09 März 2019) | 3 lines
> 
>   Update to the 2019.03.03 pre-release and switch to QT5 so that the port 
>   doesn't get deleted
>   during QT4 wipeout.
> 
> so I'm removing this from my tracker.  Less dead code is always good. :)
> 
>>> Modified: head/devel/heimdall/Makefile
>>> ==============================================================================
>>>  # does not compile with clang 6.0.0
>>> -.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1101513
>>> +.if ${OPSYS} == FreeBSD
>>>  USE_GCC=	yes
>>>  .endif
>> Yes, but shouldn't the .if simple be removed now?
>>
>> Okay, to do so, Emanuel?
> 
> Thanks for the update you made shortly thereafter that also 
> addressed this, Emanuel!

IMHO yes. The OPSYS checks were mostly introduced for compatibility with
DragonflyBSD. As far as I know we no longer actively support Dragonfly.

Emanuel