svn commit: r504198 - head/Mk

[Piotr Kubaj]

Forcing ports GCC everywhere would be a nice change to support stable branches, but it would probably also undercover some bugs in many ports (that's why I focused on adding USES manually).

s/USE_GCC=any/USE_GCC=yes/g IMO is definitely ok to commit.

On 19-07-02 00:23:47, Gerald Pfeifer wrote:
>On Sat, 15 Jun 2019, Mark Linimon wrote:
>> No, our build cluster is still using base 4.2 by default.  Most of
>> the ports that fail are fixed by specifying a USES that names a newer
>> compiler.
>
>Yep, such as the one below.  Hence my proposal to switch to a
>newer version of GCC by default where there's currently USE_GCC=any
>or similar via USES=compiler.
>
>> Clang is "coming soon".  It's a race between the folks working
>> on fixing ports on base vs. the folks working on clang :-)
>
>Well, and it surely is going to be an easier switch from current
>GCC (such as GCC 8) to current clang than from a decade old compiler
>(such as GCC 4.2).
>
>I'm not necessarily proposing to use modern GCC across the port, but
>at least where some version of GCC is explicitly requested (hence
>s/USE_GCC=any/USE_GCC=yes/g and, though that can be an independent
>change, the equivalent in Mk/Uses/compiler.mk).
>
>Gerald
>
>
>======== example commit ========
>Author: stephen
>Date: Sun Jun 30 23:32:57 2019
>New Revision: 505525
>URL: https://svnweb.freebsd.org/changeset/ports/505525
>
>Log:
>  - On GCC architectures, don't use the base GCC to build.
>
>  PR:		238885
>  Submitted by:	Piotr Kubaj <pkubaj at FreeBSD.org>
>
>Modified:
>  head/math/octave-forge-nurbs/Makefile
>
>Modified: head/math/octave-forge-nurbs/Makefile
>==============================================================================
>--- head/math/octave-forge-nurbs/Makefile	Sun Jun 30 23:10:19 2019	(r505524)
>+++ head/math/octave-forge-nurbs/Makefile	Sun Jun 30 23:32:57 2019	(r505525)
>@@ -22,8 +22,15 @@ WRKSRC=		${WRKDIR}/${OCTSRC}/src
>
> .include "${.CURDIR}/../../Mk/bsd.octave.mk"
>
>+.include <bsd.port.pre.mk>
>+
>+# Force newer GCC on platforms using GCC 4.2 as base
>+.if ${CHOSEN_COMPILER_TYPE} == gcc
>+USE_GCC=        yes
>+.endif
>+
> post-build:
> 	${RM} ${WRKSRC}/Makefile ${WRKSRC}/configure
> 	cd ${WRKDIR} && ${TAR} cfz ${DISTNAME}.tar.gz ${OCTSRC}
>
>-.include <bsd.port.mk>
>+.include <bsd.port.post.mk>
>
>
>-- 
>This message has been scanned for viruses and
>dangerous content by MailScanner, and is
>believed to be clean.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190702/72b3dd78/attachment.sig>