svn commit: r471139 - head/devel/libconfuse

[Tobias Kortkamp]

On Wed, May 30, 2018, at 20:23, Mathieu Arnold wrote:
> On Wed, May 30, 2018 at 05:47:30PM +0000, William Grzybowski wrote:
> > Author: wg
> > Date: Wed May 30 17:47:30 2018
> > New Revision: 471139
> > URL: https://svnweb.freebsd.org/changeset/ports/471139
> > 
> > Log:
> >   devel/libconfuse: update to 3.2.1
> >   
> >   PR:		227473
> >   Approved by:	maintainer timeout
> > 
> > Modified:
> >   head/devel/libconfuse/Makefile
> >   head/devel/libconfuse/distinfo
> >   head/devel/libconfuse/pkg-plist
> > 
> > Modified: head/devel/libconfuse/Makefile
> > ==============================================================================
> > --- head/devel/libconfuse/Makefile	Wed May 30 17:22:12 2018	(r471138)
> > +++ head/devel/libconfuse/Makefile	Wed May 30 17:47:30 2018	(r471139)
> > @@ -2,12 +2,14 @@
> >  # $FreeBSD$
> >  
> >  PORTNAME=	libconfuse
> > -PORTVERSION=	2.7
> > -PORTREVISION=	2
> > +DISTVERSION=	3.2.1
> >  CATEGORIES=	devel
> > -MASTER_SITES=	SAVANNAH/confuse
> > -DISTNAME=	confuse-${PORTVERSION}
> >  
> 
> The whole USE_GITHUB block happens way too early, see
> https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html
> 
> > +USE_GITHUB=	yes
> > +GH_ACCOUNT=	martinh
> > +GH_PROJECT=	libconfuse
> 
> This is the default, please remove.
> 
> > +GH_TAGNAME=	v3.2.1
> 
> Replace in favor of DISTVERSIONPREFIX=v

Wouldn't it be even better to continue using the release tarballs with
pregenerated autoconf files that upstream provides?

https://github.com/martinh/libconfuse/releases/download/v3.2.1/confuse-3.2.1.tar.gz