svn commit: r469708 - head/x11/polybar

[Tobias Kortkamp]

Author: tobik
Date: Sat May 12 07:11:22 2018
New Revision: 469708
URL: https://svnweb.freebsd.org/changeset/ports/469708

Log:
  x11/polybar: Disable ALSA by default
  
  It's broken on FreeBSD.
  
  - More modules have been tested; update pkg-message accordingly
  - Add TESTS option to build and run the unit tests
  - Fix IPC_DESC. It's built-in IPC and not i3 related.
  - Sort LIB_DEPENDS
  
  PR:		226507
  Submitted by:	Alexandre C. Guimarães <lebarondemerde at privacychain.ch> (based on)
  Approved by:	capt_redbeard at protonmail.com (maintainer timeout, 2 months)
  Differential Revision:	https://reviews.freebsd.org/D14644

Modified:
  head/x11/polybar/Makefile
  head/x11/polybar/pkg-message

Modified: head/x11/polybar/Makefile
==============================================================================
--- head/x11/polybar/Makefile	Sat May 12 06:57:39 2018	(r469707)
+++ head/x11/polybar/Makefile	Sat May 12 07:11:22 2018	(r469708)
@@ -2,7 +2,7 @@
 
 PORTNAME=	polybar
 DISTVERSION=	3.1.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	x11
 
 MAINTAINER=	capt_redbeard at protonmail.com
@@ -14,13 +14,13 @@ LICENSE_FILE=	${WRKSRC}/LICENSE
 BUILD_DEPENDS=	xcb-proto>=1.9:x11/xcb-proto
 LIB_DEPENDS=	libfontconfig.so:x11-fonts/fontconfig \
 		libfreetype.so:print/freetype2 \
-		libxcb-xrm.so:x11/xcb-util-xrm \
+		libinotify.so:devel/libinotify \
 		libxcb-cursor.so:x11/xcb-util-cursor \
 		libxcb-ewmh.so:x11/xcb-util-wm \
 		libxcb-icccm.so:x11/xcb-util-wm \
-		libxcb-util.so:x11/xcb-util \
 		libxcb-image.so:x11/xcb-util-image \
-		libinotify.so:devel/libinotify
+		libxcb-util.so:x11/xcb-util \
+		libxcb-xrm.so:x11/xcb-util-xrm
 
 USES=		cmake:outsource localbase:ldflags pkgconfig python:2.7,build
 USE_GITHUB=	yes
@@ -30,15 +30,16 @@ GH_TUPLE=	jaagr:i3ipcpp:v0.7.1:i3ipcpp/lib/i3ipcpp \
 USE_GNOME=	cairo
 USE_XORG=	xcb
 
-OPTIONS_DEFINE=	ALSA CURL EXAMPLES I3 IPC MPD
-OPTIONS_DEFAULT=	ALSA CURL I3 IPC MPD
+OPTIONS_DEFINE=	ALSA CURL EXAMPLES I3 IPC MPD TESTS
+OPTIONS_DEFAULT=	CURL I3 IPC MPD
 OPTIONS_SUB=	yes
 
 ALSA_DESC=	Volume control
 CURL_DESC=	Github support
 I3_DESC=	i3wm support
+IPC_DESC=	Built-in IPC support
 MPD_DESC=	Support for controlling MPD
-IPC_DESC=	i3 IPC support
+TESTS_DESC=	Build testsuite
 
 ALSA_CMAKE_BOOL=	ENABLE_ALSA
 ALSA_LIB_DEPENDS=	libasound.so:audio/alsa-lib
@@ -55,7 +56,13 @@ IPC_CMAKE_BOOL=		BUILD_IPC_MSG
 MPD_CMAKE_BOOL=		ENABLE_MPD
 MPD_LIB_DEPENDS=	libmpdclient.so:audio/libmpdclient
 
+TESTS_CMAKE_BOOL=	BUILD_TESTS
+
 post-patch:
 	@${REINPLACE_CMD} -e 's|python2|${PYTHON_CMD}|g' ${WRKSRC_xpp}/CMakeLists.txt
+
+do-test-TESTS-on:
+	cd ${TEST_WRKSRC} && ${SETENV} BUILD_TESTS=ON \
+		${SH} ${WRKSRC}/common/travis/tests.sh
 
 .include <bsd.port.mk>

Modified: head/x11/polybar/pkg-message
==============================================================================
--- head/x11/polybar/pkg-message	Sat May 12 06:57:39 2018	(r469707)
+++ head/x11/polybar/pkg-message	Sat May 12 07:11:22 2018	(r469708)
@@ -3,27 +3,27 @@ not function in FreeBSD.
 
 Working modules:
 - bspwm
-- cpu
 - date
+- github
 - i3
-- memory
+- ipc (polybar-msg method does not seem to work)
+- menu
+- mpd
 - script
 - text
 - xkeyboard
 - xwindow
+- xworkspaces (not extensively tested)
 
 Broken modules:
+- cpu
 - filesystem
+- memory
 - network (requires wireless_tools)
 - temperature (requires /sys/class/thermal/* in sysfs)
 - volume (requires full alsa, not a wrapper)
-- menu (does not show up)
-- xbacklight
-- xworkspaces
 
-Not tested:
+Unknown:
 - backlight
 - battery
-- github
-- ipc
-- mpd
+- xbacklight