svn commit: r469188 - head/ports-mgmt/pkg_replace

[Baptiste Daroussin]

On Sun, May 06, 2018 at 10:27:49AM +0000, Alexey Dokuchaev wrote:
> On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote:
> > New Revision: 469188
> > URL: https://svnweb.freebsd.org/changeset/ports/469188
> > 
> > Log:
> >   ports-mgmt/pkg_replace: Update to 20180424
> >   
> >   - Cleanup code
> >   - Speed up and strictly check package's dependencies
> >   - While here, pet portlint by using pkg-plist instead of PLIST_FILES
> 
> Could you explain what did you achieve by moving three-line PLIST_FILES
> into pkg-plist?  How can "pet portlint" be a reason for a change while
> we generally encourage converting <6-line pkg-plist's into PLIST_FILES?
> 
> ./danfe
> 
> > -
> > -PLIST_FILES=	sbin/pkg_replace \
> > -		man/man1/pkg_replace.1.gz \
> > -		"@sample %%ETCDIR%%/pkg_replace.conf.sample"
> 
> Correct PLIST_FILES should read:
> 
> PLIST_FILES=	sbin/pkg_replace \
> 		man/man1/pkg_replace.1.gz \
> 		@sample\ etc/pkg_replace/pkg_replace.conf.sample

why ?

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180506/63dce8b3/attachment.sig>