svn commit: r463618 - head/sysutils/htop
Yuri
yuri at freebsd.org
Mon Mar 5 18:12:01 UTC 2018
On 03/05/18 08:57, Sunpoet Po-Chuan Hsieh wrote:
>
> scripts/MakeHeader.py is no-op in fact.
> It is used to generate header files but all header files are all ready
> in the tarball.
> I've run the script manually with python 3.6 and the generated header
> files are identical with the ones from the tarball.
>
> USES=shebangfix is also unnecessary because scripts/MakeHeader.py is
> unused.
I saw this, and decided to keep USES=shebangfix. The reason was that
MakeHeader.py file is only not run because all .h files are newer than
.c files. If you will touch any .c file after extract, MakeHeader.py
will be run. So it depends on timestamps, which is arbitrary and might
change with the next release, making it error-prone.
I asked them to fix this: https://github.com/hishamhm/htop/issues/754
> This port can be built without USES=localbase.
For some reason, it fails for me without USES=localbase. It can't find
ncurses.h
Again, I asked them to fix it: https://github.com/hishamhm/htop/issues/755
Yuri
More information about the svn-ports-all
mailing list