svn commit: r474520 - head/x11-clocks/glclock

[Dmitry Marakasov]

* Tobias Kortkamp (tobik at FreeBSD.org) wrote:

> > Author: amdmi3
> > Date: Thu Jul 12 14:11:46 2018
> > New Revision: 474520
> > URL: https://svnweb.freebsd.org/changeset/ports/474520
> > 
> > Log:
> >   - Fix build with clang 6
> > 
> > Modified:
> >   head/x11-clocks/glclock/Makefile
> > 
> > Modified: head/x11-clocks/glclock/Makefile
> > ==============================================================================
> > --- head/x11-clocks/glclock/Makefile	Thu Jul 12 14:11:30 2018	(r474519)
> > +++ head/x11-clocks/glclock/Makefile	Thu Jul 12 14:11:46 2018	(r474520)
> > @@ -15,6 +15,7 @@ USE_GL=		gl glu glut
> >  MAKEFILE=	makefile
> >  
> >  CFLAGS+=	-DIMAGE_PATH="\\\"${PREFIX}/lib/X11/glclock/\\\""
> > +CXXFLAGS+=	-Wno-c++11-narrowing
> 
> Why is this needed after r474251?  Was the previous fix not enough?

It wasn't, I wasn't aware of your fix.

> Besides that this breaks the build on Tier 2 archs like powerpc.
> gcc 4.2 doesn't recognize -Wno-c++11-narrowing and treats it as an
> error:
> 
> cc1plus: error: unrecognized command line option "-Wno-c++11-narrowing"
> 
> I think something like
> 
> USES=		compiler
> CXXFLAGS+=	${CXXFLAGS_${CHOSEN_COMPILER_TYPE}}
> CXXFLAGS_clang=	-Wno-c++11-narrowing
> 
> or similar would be better.

This is too cumbersome. If it comes to this, this should be added to the
framework as compiler:legacycode or something like that. But I really
prefer for such fixes it to be in the Makefile and not a patch, as it
makes the existence of rotten code more apparent, and makes garbage
collecting either the fix (if the code is fixed upstream) or the whole
port (as unmaintained legacy) easier.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:              https://github.com/AMDmi3