svn commit: r459751 - in head/lang: . solidity solidity/files

[Alex Dupre]

Alexey Dokuchaev wrote:
> On Tue, Jan 23, 2018 at 01:58:22PM +0000, Alex Dupre wrote:
>> New Revision: 459751
>> URL: https://svnweb.freebsd.org/changeset/ports/459751
>>
>> Log:
>>   The Solidity Contract-Oriented Programming Language
>>   
>>   WWW: https://github.com/ethereum/solidity
>>
>> Added: head/lang/solidity/Makefile
>> ...

Hi Alexey, I often agree with your comments, but this time I have to
strongly disagree.

% portlint -tac solidity/
looks fine.

>> +COMMENT=	Solidity Contract-Oriented Programming Language
> 
> COMMENT=	Contract-oriented programming language

Come on, then the comment for the scala port should be "Programming
Language"?

> 
>> +OPTIONS_DEFINE=	SMT
>> +SMT_DESC=	SMT Checker
>> +SMT_LIB_DEPENDS=libz3.so:math/z3
>> +
>> +USES=		cmake
> 
> Misplaced USES.

I don't see what's misplaced here, portlint doesn't seem to agree with you.

>> +CMAKE_ARGS+=	-DUSE_LD_GOLD=OFF -DTESTS=OFF \
>> +		-DJSONCPP_INCLUDE_DIR:STRING="${LOCALBASE}/include/jsoncpp" \
>> +		-DJSONCPP_LIB_DIR:STRING="${LOCALBASE}/lib"
> 
> And CMAKE_ARGS (also bogus +=).

Really?

>> +pre-patch:
>> +		@${CP} ${FILESDIR}/jsoncpp.cmake ${WRKSRC}/cmake/
>> +		@${REINPLACE_CMD} '/EthCcache/d' ${WRKSRC}/CMakeLists.txt
> 
> Excessive indentation of target recipe (commands).

Seriously?

>> Added: head/lang/solidity/pkg-descr
>> ...
>> @@ -0,0 +1,3 @@
>> +The Solidity Contract-Oriented Programming Language
>> +
>> +WWW: https://github.com/ethereum/solidity
> 
> Bad port description (verbatim copy of COMMENT), tells nothing about the
> port (violation of PHB Section 3.2.1).
This is the only thing I agree on, changed.

-- 
Alex Dupre