svn commit: r458645 - head/textproc/jade/files

Jan Beich jbeich at FreeBSD.org
Wed Jan 10 15:28:41 UTC 2018


Alexey Dokuchaev <danfe at FreeBSD.org> writes:

> On Wed, Jan 10, 2018 at 02:50:52PM +0000, Jan Beich wrote:
>
>> New Revision: 458645
>> URL: https://svnweb.freebsd.org/changeset/ports/458645
>> 
>> Log:
>>   textproc/jade: regen via "make makepatch"
>
> Can we please *not* do this just to please portlint(1)?

I've found it hard to read existing patches:
- Patch files were named inconsistently
- Context lines were out of date
- Dates were bogus
- Context lacked C function
- One patch was in context diff format

> Patches tend to come and go, they are volatile enough to simply let
> the old, unconformant ones die naturally.

Can you say the same about this port?

- 1.2.1 is from ~19 years ago
- 1.2.1-35 patch is from ~15 years ago

> Regenerating them for no other purpose just creates unneeded repo
> churn and jeopardizes the history.

OK. Backed out in r458647.


More information about the svn-ports-all mailing list