svn commit: r458124 - in head/databases: mysql56-client/files mysql56-server mysql56-server/files

[Jan Beich]

Author: jbeich
Date: Fri Jan  5 10:54:41 2018
New Revision: 458124
URL: https://svnweb.freebsd.org/changeset/ports/458124

Log:
  databases/mysql56-server: unbreak build with Clang 6 (C++14 by default)
  
  sql-common/client_authentication.cc:87:56: error: comparison between pointer and integer ('char *' and 'int')
        mysql->options.extension->server_public_key_path != '\0')
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
  
  sql/sql_trigger.cc:195:5: error:
        non-constant-expression cannot be narrowed from type 'int' to 'size_t' (aka 'unsigned long') in
        initializer list [-Wc++11-narrowing]
      static_cast<int>(my_offsetof(class Table_triggers_list, definitions_list)),
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  
  Reported by:	antoine (via bug 224669)

Added:
  head/databases/mysql56-client/files/patch-sql-common_client__authentication.cc   (contents, props changed)
  head/databases/mysql56-server/files/patch-sql-common_client__authentication.cc   (contents, props changed)
Deleted:
  head/databases/mysql56-server/files/patch-sql_sql_trigger.cc
  head/databases/mysql56-server/files/patch-sql_sql_view.cc
Modified:
  head/databases/mysql56-server/Makefile   (contents, props changed)

Added: head/databases/mysql56-client/files/patch-sql-common_client__authentication.cc
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/databases/mysql56-client/files/patch-sql-common_client__authentication.cc	Fri Jan  5 10:54:41 2018	(r458124)
@@ -0,0 +1,17 @@
+sql-common/client_authentication.cc:87:56: error: comparison between pointer and integer ('char *' and 'int')
+      mysql->options.extension->server_public_key_path != '\0')
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
+
+Part of https://github.com/mysql/mysql-server/commit/db1bde79b1b4
+
+--- sql-common/client_authentication.cc.orig	2017-09-13 15:49:17 UTC
++++ sql-common/client_authentication.cc
+@@ -84,7 +84,7 @@ RSA *rsa_init(MYSQL *mysql)
+ 
+   if (mysql->options.extension != NULL &&
+       mysql->options.extension->server_public_key_path != NULL &&
+-      mysql->options.extension->server_public_key_path != '\0')
++      mysql->options.extension->server_public_key_path[0] != '\0')
+   {
+     pub_key_file= fopen(mysql->options.extension->server_public_key_path,
+                         "r");

Modified: head/databases/mysql56-server/Makefile
==============================================================================
--- head/databases/mysql56-server/Makefile	Fri Jan  5 09:26:49 2018	(r458123)
+++ head/databases/mysql56-server/Makefile	Fri Jan  5 10:54:41 2018	(r458124)
@@ -3,7 +3,7 @@
 
 PORTNAME?=	mysql
 PORTVERSION=	5.6.38
-PORTREVISION=	0
+PORTREVISION=	1
 CATEGORIES=	databases ipv6
 MASTER_SITES=	MYSQL/MySQL-5.6
 PKGNAMESUFFIX?=	56-server

Added: head/databases/mysql56-server/files/patch-sql-common_client__authentication.cc
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/databases/mysql56-server/files/patch-sql-common_client__authentication.cc	Fri Jan  5 10:54:41 2018	(r458124)
@@ -0,0 +1,17 @@
+sql-common/client_authentication.cc:87:56: error: comparison between pointer and integer ('char *' and 'int')
+      mysql->options.extension->server_public_key_path != '\0')
+      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~
+
+Part of https://github.com/mysql/mysql-server/commit/db1bde79b1b4
+
+--- sql-common/client_authentication.cc.orig	2017-09-13 15:49:17 UTC
++++ sql-common/client_authentication.cc
+@@ -84,7 +84,7 @@ RSA *rsa_init(MYSQL *mysql)
+ 
+   if (mysql->options.extension != NULL &&
+       mysql->options.extension->server_public_key_path != NULL &&
+-      mysql->options.extension->server_public_key_path != '\0')
++      mysql->options.extension->server_public_key_path[0] != '\0')
+   {
+     pub_key_file= fopen(mysql->options.extension->server_public_key_path,
+                         "r");