svn commit: r468319 - in head/mail: opensmtpd opensmtpd-devel opensmtpd-devel/files opensmtpd/files

[Adam Weinberger]

> On 26 Apr, 2018, at 20:30, Dima Panov <fuffy at FreeBSD.org> wrote:
>
>
>
> Adam Weinberger wrote:
>>> On 25 Apr, 2018, at 18:53, Dima Panov <fluffy at FreeBSD.org> wrote:
>>>
>>> Author: fluffy
>>> Date: Thu Apr 26 00:53:01 2018
>>> New Revision: 468319
>>> URL: https://svnweb.freebsd.org/changeset/ports/468319
>>>
>>> Log:
>>>   - Pet MDA part, add brackets around Return-Path as per RFC5322 §3.6.6.
>>>
>>>   Missing brackets lead to a panic when a malformed address line
>>>   is fed to dovecot-lda
>>>
>>>   Submitted by:    gahr
>>>   Reported by:    brnrd via dovecot ML
>>>   Obtained from:    https://github.com/OpenSMTPD/OpenSMTPD/pull/847/commits/725ba4fa2ddf23bbcd1ff9ec92e86bbfaa6825c8
>> Thanks for doing this, Dima. This should probably be merged to  
>> quarterly, no?
>
> Only Dovecot23+ affected this "bug" yet, so while 2018Q2 lives without  
> it, MFH is not critically needed.
> But yes, I'm also thinking about MFH, just to be sured in.

IIRC rspamd had to work around this behavior a while back. It’s certainly a  
bug fix, but only dovecot seems to have broken spectacularly here recently.

I don’t feel strongly about it one way or the other. I defer to your  
judgement.

# Adam


—
Adam Weinberger
adamw at adamw.org
http://www.adamw.org