svn commit: r468181 - in head/security/py-obfsproxy-tor: . files

[Kubilay Kocak]

On 24/04/2018 4:30 pm, Fukang Chen wrote:
> Author: loader (doc committer)
> Date: Tue Apr 24 06:30:56 2018
> New Revision: 468181
> URL: https://svnweb.freebsd.org/changeset/ports/468181
> 
> Log:
>   security/py-obfsproxy-tor: Fix runtime dependency error
>   
>   - Change runtime dependency entry point Twisted_Core back to Twisted
>   - Update checksum for CHEESESHOP

I didn't notice the distinfo change in the review, and should have
picked up on it earlier. Apologies for that.

Could you clarify the source/reason for the checksum change?

When this happens, one should always:

- Investigate the reason for the source (without version) update.
- Include those findings (where available) for what happened and why in
the commit log message.
- Include a description/summary of the material source changes, if any,
and relevant, with upstream references/links where available.

>   - Add test target
>   
>   Reviewed by:	cs, koobs
>   Approved by:	cs (maintainer), koobs (ports)
>   Differential Revision:	https://reviews.freebsd.org/D13452
>   MFH:		2018Q2
> 
> Modified:
>   head/security/py-obfsproxy-tor/Makefile
>   head/security/py-obfsproxy-tor/distinfo
>   head/security/py-obfsproxy-tor/files/patch-setup.py
> 
> Modified: head/security/py-obfsproxy-tor/Makefile
> ==============================================================================
> --- head/security/py-obfsproxy-tor/Makefile	Tue Apr 24 06:18:04 2018	(r468180)
> +++ head/security/py-obfsproxy-tor/Makefile	Tue Apr 24 06:30:56 2018	(r468181)
> @@ -20,6 +20,7 @@ RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pyptlib>=0.0.5:sec
>  		${PYTHON_PKGNAMEPREFIX}pycrypto>=2.1:security/py-pycrypto@${FLAVOR} \
>  		${PYTHON_PKGNAMEPREFIX}twisted>=0:devel/py-twisted@${FLAVOR} \
>  		${PYTHON_PKGNAMEPREFIX}yaml>=0:devel/py-yaml@${FLAVOR}
> +TEST_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pytest>0:devel/py-pytest@${FLAVOR}
>  
>  USES=		python:2.7
>  USE_PYTHON=	distutils autoplist
> @@ -27,5 +28,8 @@ SUB_FILES=	pkg-message
>  NO_ARCH=	yes
>  
>  PYDISTUTILS_PKGNAME=	obfsproxy
> +
> +do-test:
> +	@(cd ${TEST_WRKSRC} && ${SETENV} ${TEST_ENV} ${PYTHON_CMD} -m pytest)
>  
>  .include <bsd.port.mk>
> 
> Modified: head/security/py-obfsproxy-tor/distinfo
> ==============================================================================
> --- head/security/py-obfsproxy-tor/distinfo	Tue Apr 24 06:18:04 2018	(r468180)
> +++ head/security/py-obfsproxy-tor/distinfo	Tue Apr 24 06:30:56 2018	(r468181)
> @@ -1,3 +1,3 @@
> -TIMESTAMP = 1519975368
> -SHA256 (obfsproxy-0.2.13.tar.gz) = c29582f2f5b0316cbc7184e0529a5b246dfeeabd4e6c4dcb05b800256d6c9dd6
> -SIZE (obfsproxy-0.2.13.tar.gz) = 95813
> +TIMESTAMP = 1512989600
> +SHA256 (obfsproxy-0.2.13.tar.gz) = 1e26c2faef1cfcf856ddf60e9647058a7c78fb0d47f05b58a0f847ed7cc41a66
> +SIZE (obfsproxy-0.2.13.tar.gz) = 93435
> 
> Modified: head/security/py-obfsproxy-tor/files/patch-setup.py
> ==============================================================================
> --- head/security/py-obfsproxy-tor/files/patch-setup.py	Tue Apr 24 06:18:04 2018	(r468180)
> +++ head/security/py-obfsproxy-tor/files/patch-setup.py	Tue Apr 24 06:30:56 2018	(r468181)
> @@ -1,19 +1,10 @@
> ---- setup.py.orig	2014-12-31 15:34:31 UTC
> +--- setup.py.orig	2014-08-21 09:28:57 UTC
>  +++ setup.py
> -@@ -31,12 +31,14 @@ setup(
> -     install_requires = [
> +@@ -32,7 +32,6 @@ setup(
>           'setuptools',
>           'PyCrypto',
> --        'Twisted',
> +         'Twisted',
>  -        'argparse',
> -+        'Twisted_Core',
>           'pyptlib >= 0.0.6',
>           'pyyaml'
>           ],
> - 
> -+    #if sys.version_info < (2, 7):
> -+    #    install_requires.append('argparse')
> -+
> -     extras_require = {
> -         'SOCKS': ["txsocksx"]
> -         }
>