svn commit: r467762 - head/devel/git

[Steve Wills]

Hi,

Glad you bumped PORTREVISION but the commit message implies you didn't 
need to if the GITWEB option wasn't on by default. The Porters handbook 
disagrees:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html

PORTREVISION must be increased each time a change is made to the port 
that changes the generated package in any way. That includes changes 
that only affect a package built with non-default options.

Just picking a random instance here since you're not the only one who 
has thought this. So I point it out to everyone for future reference.

Steve

On 04/19/2018 06:05, Renato Botelho wrote:
> Author: garga
> Date: Thu Apr 19 10:05:44 2018
> New Revision: 467762
> URL: https://svnweb.freebsd.org/changeset/ports/467762
> 
> Log:
>    - Register p5-CGI dependency when GITWEB option is enabled [1]
>    - Bump PORTREVISION since GITWEB is on by default
>    - While here, unmute install command and make portlint happy
>    
>    PR:		225358 [1]
>    Submitted by:	Fabian Kell <fk at fabiankeil.de> [1]
>    MFH:		2018Q2
>    Sponsored by:	Rubicon Communications, LLC (Netgate)
> 
> Modified:
>    head/devel/git/Makefile
> 
> Modified: head/devel/git/Makefile
> ==============================================================================
> --- head/devel/git/Makefile	Thu Apr 19 10:02:45 2018	(r467761)
> +++ head/devel/git/Makefile	Thu Apr 19 10:05:44 2018	(r467762)
> @@ -3,6 +3,7 @@
>   
>   PORTNAME=	git
>   DISTVERSION=	2.17.0
> +PORTREVISION=	1
>   CATEGORIES=	devel
>   MASTER_SITES=	KERNEL_ORG/software/scm/git
>   DISTFILES=	${DISTNAME}${EXTRACT_SUFX} \
> @@ -74,6 +75,7 @@ PERL_RUN_DEPENDS=	p5-Error>=0:lang/p5-Error
>   PERL_MAKE_ARGS_OFF=	NO_PERL=1
>   
>   GITWEB_IMPLIES=		PERL
> +GITWEB_RUN_DEPENDS=	p5-CGI>=0:www/p5-CGI
>   
>   PCRE_LIB_DEPENDS=	libpcre.so:devel/pcre
>   PCRE_CONFIGURE_WITH=	libpcre
> @@ -226,7 +228,7 @@ post-install-CONTRIB-on:
>   post-install-CONTRIB-off:
>   	# Install the contrib completions anyway
>   	@${MKDIR} ${STAGEDIR}${PREFIX}/etc/bash_completion.d
> -	@${INSTALL_SCRIPT} ${WRKSRC}/contrib/completion/git-completion.bash \
> +	${INSTALL_SCRIPT} ${WRKSRC}/contrib/completion/git-completion.bash \
>   		${STAGEDIR}${PREFIX}/etc/bash_completion.d/git.sh
>   
>   post-install-P4-on:
>